Skip to content

Commit f9655d8

Browse files
committed
helm: add global.imagePullSecrets in values.yaml
Used but previously missing from values.yaml.
1 parent 42eeb21 commit f9655d8

File tree

3 files changed

+25
-0
lines changed

3 files changed

+25
-0
lines changed

deployment/helm/node-feature-discovery/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,12 @@ for more detailed deployment instructions.
3939
| priorityClassName | string | `""` | The name of the PriorityClass to be used for the NFD pods. |
4040
| postDeleteCleanup | bool | `true` | Enable/disable the Helm post-delete hook. |
4141

42+
### Global
43+
44+
| Key | Type | Default | Description |
45+
|-----|------|---------|-------------|
46+
| global.imagePullSecrets | list | `[]` | If `imagePullSecrets` is specified, it takes precedence over `global.imagePullSecrets`. [More info](https://kubernetes.io/docs/concepts/containers/images#specifying-imagepullsecrets-on-a-pod). |
47+
4248
### NFD-Master
4349

4450
| Key | Type | Default | Description |

deployment/helm/node-feature-discovery/values.schema.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,16 @@
218218
}
219219
}
220220
},
221+
"global": {
222+
"type": "object",
223+
"properties": {
224+
"imagePullSecrets": {
225+
"description": "If `imagePullSecrets` is specified, it takes precedence over `global.imagePullSecrets`. [More info](https://kubernetes.io/docs/concepts/containers/images#specifying-imagepullsecrets-on-a-pod).",
226+
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.34.1/_definitions.json#/definitions/io.k8s.api.core.v1.PodSpec/properties/imagePullSecrets",
227+
"type": "array"
228+
}
229+
}
230+
},
221231
"image": {
222232
"type": "object",
223233
"properties": {

deployment/helm/node-feature-discovery/values.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,15 @@ priorityClassName: ""
3838
# @section -- General
3939
postDeleteCleanup: true
4040

41+
#
42+
# Global configuration for NFD used as a sub-chart
43+
#
44+
global:
45+
# @schema $ref: $k8s/_definitions.json#/definitions/io.k8s.api.core.v1.PodSpec/properties/imagePullSecrets
46+
# -- If `imagePullSecrets` is specified, it takes precedence over `global.imagePullSecrets`. [More info](https://kubernetes.io/docs/concepts/containers/images#specifying-imagepullsecrets-on-a-pod).
47+
# @section -- Global
48+
imagePullSecrets: []
49+
4150
#
4251
# NFD-Master configuration
4352
#

0 commit comments

Comments
 (0)