Skip to content

Commit fb5e0bd

Browse files
authored
Merge pull request #2340 from almaslennikov/patch-1
fix: allow helm chart to use object type in worker and master config
2 parents 4ea1e13 + d96b6ef commit fb5e0bd

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

deployment/helm/node-feature-discovery/values.schema.json

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,10 @@
273273
},
274274
"config": {
275275
"description": "NFD master [configuration](https://kubernetes-sigs.github.io/node-feature-discovery/master/reference/master-configuration-reference).",
276-
"type": "null"
276+
"type": [
277+
"object",
278+
"null"
279+
]
277280
},
278281
"denyLabelNs": {
279282
"description": "Label namespaces to deny. Labels with these prefixes will not be published to the nodes.",
@@ -596,7 +599,10 @@
596599
},
597600
"config": {
598601
"description": "Configuration for the topology updater. See the [configuration reference](https://kubernetes-sigs.github.io/node-feature-discovery/master/reference/topology-updater-configuration-reference) for details.",
599-
"type": "null"
602+
"type": [
603+
"object",
604+
"null"
605+
]
600606
},
601607
"createCRDs": {
602608
"description": "Create CustomResourceDefinitions for the TopologyUpdater.",
@@ -825,7 +831,10 @@
825831
},
826832
"config": {
827833
"description": "NFD worker [configuration](https://kubernetes-sigs.github.io/node-feature-discovery/master/reference/worker-configuration-reference).",
828-
"type": "null"
834+
"type": [
835+
"object",
836+
"null"
837+
]
829838
},
830839
"daemonsetAnnotations": {
831840
"description": "[Annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations) to add to the nfd-worker DaemonSet.",

deployment/helm/node-feature-discovery/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ master:
6969
# -- NFD master pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy).
7070
# @section -- NFD-Master
7171
dnsPolicy: ClusterFirstWithHostNet
72+
# @schema type: [object, null]
7273
# -- NFD master [configuration](https://kubernetes-sigs.github.io/node-feature-discovery/master/reference/master-configuration-reference).
7374
# @section -- NFD-Master
7475
config: ### <NFD-MASTER-CONF-START-DO-NOT-REMOVE>
@@ -341,6 +342,7 @@ worker:
341342
# -- NFD worker pod [dnsPolicy](https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-policy).
342343
# @section -- NFD-Worker
343344
dnsPolicy: ClusterFirstWithHostNet
345+
# @schema type: [object, null]
344346
# -- NFD worker [configuration](https://kubernetes-sigs.github.io/node-feature-discovery/master/reference/worker-configuration-reference).
345347
# @section -- NFD-Worker
346348
config: ### <NFD-WORKER-CONF-START-DO-NOT-REMOVE>
@@ -725,6 +727,7 @@ worker:
725727
# NFD-Topology-Updater configuration
726728
#
727729
topologyUpdater:
730+
# @schema type: [object, null]
728731
# -- Configuration for the topology updater. See the [configuration reference](https://kubernetes-sigs.github.io/node-feature-discovery/master/reference/topology-updater-configuration-reference) for details.
729732
# @section -- NFD-Topology-Updater
730733
config: ### <NFD-TOPOLOGY-UPDATER-CONF-START-DO-NOT-REMOVE>

0 commit comments

Comments
 (0)