address review comments

Author: sats-23

kubetest2-tf/data/k8s-ansible/install-k8s-monitoring.yml

@@ -1,18 +1,16 @@
 ---
-- name: Ensure kubernetes.core collection is installed
+- name: Deploy kube-prometheus-stack to Kubernetes
   hosts: masters
   gather_facts: no
+  become: yes
+
   tasks:
-    - name: Install required Ansible collection
-      ansible.builtin.command:
-        cmd: ansible-galaxy collection install kubernetes.core
+    - name: Ensure kubernetes.core collection is installed
+      command: ansible-galaxy collection install kubernetes.core
       changed_when: false
       delegate_to: "{{ groups['masters'][0] }}"
+      become: no
 
-- name: Install Helm
-  hosts: masters
-  become: yes
-  tasks:
     - name: Download Helm install script
       ansible.builtin.get_url:
         url: https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
@@ -21,13 +19,9 @@
       delegate_to: "{{ groups['masters'][0] }}"
 
     - name: Run Helm install script
-      ansible.builtin.command: /tmp/get_helm.sh
-      args:
-        chdir: /tmp
+      command: /tmp/get_helm.sh
       delegate_to: "{{ groups['masters'][0] }}"
 
-- name: Deploy kube-prometheus-stack to Kubernetes
-  hosts: masters
-  become: yes
   roles:
-    - install-monitoring
+    - role: install-monitoring
+      name: Deploy kube-prometheus-stack

kubetest2-tf/data/k8s-ansible/roles/install-monitoring/defaults/main.yml

@@ -1,4 +1,4 @@
-
+#Default vars for install-monitoring role
 ---
 helm_release_name: k8s-monitoring
 helm_chart_name: prometheus-community/kube-prometheus-stack

kubetest2-tf/data/k8s-ansible/roles/install-monitoring/tasks/main.yml

@@ -1,6 +1,6 @@
 ---
 - name: Ensure namespace exists
-  ansible.builtin.command: kubectl create namespace {{ helm_namespace }}
+  command: kubectl create namespace {{ helm_namespace }}
   ignore_errors: yes # Ignore error if namespace already exists
 
 - name: Ensure Helm repository is added