Merge pull request #492 from Fish-pro/chore/unused

Clean up unused variables and functions

Author: k8s-ci-robot

pkg/capacityscheduling/capacity_scheduling.go

@@ -793,13 +793,6 @@ func getPDBLister(informerFactory informers.SharedInformerFactory) policylisters
 	return informerFactory.Policy().V1().PodDisruptionBudgets().Lister()
 }
 
-func getPodDisruptionBudgets(pdbLister policylisters.PodDisruptionBudgetLister) ([]*policy.PodDisruptionBudget, error) {
-	if pdbLister != nil {
-		return pdbLister.List(labels.Everything())
-	}
-	return nil, nil
-}
-
 // computePodResourceRequest returns a framework.Resource that covers the largest
 // width in each resource dimension. Because init-containers run sequentially, we collect
 // the max in each dimension iteratively. In contrast, we sum the resource vectors for

pkg/coscheduling/core/core.go

@@ -79,8 +79,6 @@ type PodGroupManager struct {
 	pgLister pglister.PodGroupLister
 	// podLister is pod lister
 	podLister listerv1.PodLister
-	// reserveResourcePercentage is the reserved resource for the max finished group, range (0,100]
-	reserveResourcePercentage int32
 	sync.RWMutex
 }
 

pkg/coscheduling/coscheduling.go

@@ -23,7 +23,6 @@ import (
 
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/tools/cache"
 	corev1helpers "k8s.io/component-helpers/scheduling/corev1"
 	"k8s.io/klog/v2"
@@ -238,12 +237,3 @@ func (cs *Coscheduling) PostBind(ctx context.Context, _ *framework.CycleState, p
 	klog.V(5).InfoS("PostBind", "pod", klog.KObj(pod))
 	cs.pgMgr.PostBind(ctx, pod, nodeName)
 }
-
-// rejectPod rejects pod in cache
-func (cs *Coscheduling) rejectPod(uid types.UID) {
-	waitingPod := cs.frameworkHandler.GetWaitingPod(uid)
-	if waitingPod == nil {
-		return
-	}
-	waitingPod.Reject(Name, "")
-}

pkg/networkaware/networkoverhead/networkoverhead_test.go

@@ -31,7 +31,6 @@ import (
 	"k8s.io/client-go/informers"
 	testClientSet "k8s.io/client-go/kubernetes/fake"
 	"k8s.io/client-go/util/workqueue"
-	"k8s.io/klog/v2"
 	"k8s.io/kubernetes/pkg/scheduler/framework"
 	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/defaultbinder"
 	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/queuesort"
@@ -1611,14 +1610,3 @@ func makePodAllocated(selector string, podName string, hostname string, priority
 		},
 	}
 }
-
-// podScheduled returns true if a node is assigned to the given pod.
-func podScheduled(c *testClientSet.Clientset, podNamespace, podName string) bool {
-	pod, err := c.CoreV1().Pods(podNamespace).Get(context.TODO(), podName, metav1.GetOptions{})
-	if err != nil {
-		// This could be a connection error so we want to retry.
-		klog.ErrorS(err, "Failed to get pod", "pod", klog.KRef(podNamespace, podName))
-		return false
-	}
-	return pod.Spec.NodeName != ""
-}

pkg/trimaran/loadvariationriskbalancing/analysis_test.go

@@ -20,54 +20,8 @@ import (
 	"math"
 	"testing"
 
-	"github.com/paypal/load-watcher/pkg/watcher"
 	"github.com/stretchr/testify/assert"
 	"sigs.k8s.io/scheduler-plugins/pkg/trimaran"
-
-	v1 "k8s.io/api/core/v1"
-	st "k8s.io/kubernetes/pkg/scheduler/testing"
-)
-
-var (
-	metrics = []watcher.Metric{
-		{
-			Name:     "no_name",
-			Type:     watcher.CPU,
-			Operator: "",
-			Value:    40,
-		},
-		{
-			Name:     "cpu_running_avg",
-			Type:     watcher.CPU,
-			Operator: watcher.Average,
-			Value:    40,
-		},
-		{
-			Name:     "cpu_running_std",
-			Type:     watcher.CPU,
-			Operator: watcher.Std,
-			Value:    36,
-		},
-		{
-			Name:     "mem_running_avg",
-			Type:     watcher.Memory,
-			Operator: watcher.Average,
-			Value:    20,
-		},
-		{
-			Name:     "mem_running_std",
-			Type:     watcher.Memory,
-			Operator: watcher.Std,
-			Value:    10,
-		},
-	}
-
-	nodeResources = map[v1.ResourceName]string{
-		v1.ResourceCPU:    "1000m",
-		v1.ResourceMemory: "1Gi",
-	}
-
-	node0 = st.MakeNode().Name("node0").Capacity(nodeResources).Obj()
 )
 
 func TestComputeScore(t *testing.T) {

pkg/util/podgroup_test.go

@@ -22,12 +22,6 @@ import (
 	"k8s.io/kubernetes/pkg/apis/core"
 )
 
-type test struct {
-	old           interface{}
-	new           interface{}
-	expectedError bool
-}
-
 func TestCreateMergePatch(t *testing.T) {
 	tests := []struct {
 		old      interface{}