Skip to content

Commit 0ab88ad

Browse files
authored
Merge pull request #589 from ffromani/nrt-improve-debuggability
nodetopologymatch: bump podfingerprint package to improve debuggability
2 parents 4b367bc + 76b60f9 commit 0ab88ad

File tree

15 files changed

+59
-2326
lines changed

15 files changed

+59
-2326
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ require (
99
github.com/go-logr/logr v1.2.3
1010
github.com/google/go-cmp v0.5.9
1111
github.com/k8stopologyawareschedwg/noderesourcetopology-api v0.1.1
12-
github.com/k8stopologyawareschedwg/podfingerprint v0.2.0
12+
github.com/k8stopologyawareschedwg/podfingerprint v0.2.2
1313
github.com/patrickmn/go-cache v2.1.0+incompatible
1414
github.com/paypal/load-watcher v0.2.2
1515
github.com/spf13/pflag v1.0.5

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,8 @@ github.com/julienschmidt/httprouter v1.2.0/go.mod h1:SYymIcj16QtmaHHD7aYtjjsJG7V
297297
github.com/julienschmidt/httprouter v1.3.0/go.mod h1:JR6WtHb+2LUe8TCKY3cZOxFyyO8IZAc4RVcycCCAKdM=
298298
github.com/k8stopologyawareschedwg/noderesourcetopology-api v0.1.1 h1:BI3L7hNqRvXtB42FO4NI/0ZjDDVRPOMBDFLShhFtf28=
299299
github.com/k8stopologyawareschedwg/noderesourcetopology-api v0.1.1/go.mod h1:AkACMQGiTgCt0lQw3m7TTU8PLH9lYKNK5e9DqFf5VuM=
300-
github.com/k8stopologyawareschedwg/podfingerprint v0.2.0 h1:3Wc58WPBqG0yry0noEARZIAljBOU7TQZDg1L7dQTyw0=
301-
github.com/k8stopologyawareschedwg/podfingerprint v0.2.0/go.mod h1:C23pM15t06dXg/OihGlqBvnYzLr+MXDXJ7zMfbNAyXI=
300+
github.com/k8stopologyawareschedwg/podfingerprint v0.2.2 h1:iFHPfZInM9pz2neye5RdmORMp1hPmte1EGJYpOOzZVg=
301+
github.com/k8stopologyawareschedwg/podfingerprint v0.2.2/go.mod h1:C23pM15t06dXg/OihGlqBvnYzLr+MXDXJ7zMfbNAyXI=
302302
github.com/kisielk/errcheck v1.5.0/go.mod h1:pFxgyoBC7bSaBwPgfKdkLd5X25qrDl4LWUI2bnpBCr8=
303303
github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck=
304304
github.com/konsorten/go-windows-terminal-sequences v1.0.1/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ=

pkg/noderesourcetopology/cache/store.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,9 @@ func checkPodFingerprintForNode(logID string, objs []types.NamespacedName, nodeN
222222
klog.V(5).InfoS("nrtcache: podset fingerprint check", "logID", logID, "node", nodeName, "expected", pfpExpected, "computed", pfpComputed)
223223
klog.V(6).InfoS("nrtcache: podset fingerprint debug", "logID", logID, "node", nodeName, "status", st.Repr())
224224

225-
return pfp.Check(pfpExpected)
225+
err := pfp.Check(pfpExpected)
226+
podfingerprint.MarkCompleted(st)
227+
return err
226228
}
227229

228230
func makeNodeToNamespacedNamesMap(podLister podlisterv1.PodLister, logID string) (map[string][]types.NamespacedName, error) {

vendor/github.com/k8stopologyawareschedwg/podfingerprint/notify.go

Lines changed: 43 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/k8stopologyawareschedwg/podfingerprint/podfingerprint.go

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/k8s.io/kubernetes/pkg/apis/core/install/OWNERS

Lines changed: 0 additions & 9 deletions
This file was deleted.

vendor/k8s.io/kubernetes/pkg/apis/core/install/install.go

Lines changed: 0 additions & 38 deletions
This file was deleted.

vendor/k8s.io/kubernetes/pkg/controller/OWNERS

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)