Skip to content

Commit 25ad632

Browse files
committed
cleanup: remove metav1.TypeMeta when composing CR objects
1 parent 0fb11f8 commit 25ad632

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

test/integration/capacity_scheduling_test.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ func TestCapacityScheduling(t *testing.T) {
131131
},
132132
elasticQuotas: []*v1alpha1.ElasticQuota{
133133
{
134-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
135134
ObjectMeta: metav1.ObjectMeta{Name: "eq1", Namespace: "ns1"},
136135
Spec: v1alpha1.ElasticQuotaSpec{
137136
Min: v1.ResourceList{
@@ -145,7 +144,6 @@ func TestCapacityScheduling(t *testing.T) {
145144
},
146145
},
147146
{
148-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
149147
ObjectMeta: metav1.ObjectMeta{Name: "eq2", Namespace: "ns2"},
150148
Spec: v1alpha1.ElasticQuotaSpec{
151149
Min: v1.ResourceList{
@@ -189,7 +187,6 @@ func TestCapacityScheduling(t *testing.T) {
189187
},
190188
elasticQuotas: []*v1alpha1.ElasticQuota{
191189
{
192-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
193190
ObjectMeta: metav1.ObjectMeta{Name: "eq1", Namespace: "ns1"},
194191
Spec: v1alpha1.ElasticQuotaSpec{
195192
Min: v1.ResourceList{
@@ -203,7 +200,6 @@ func TestCapacityScheduling(t *testing.T) {
203200
},
204201
},
205202
{
206-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
207203
ObjectMeta: metav1.ObjectMeta{Name: "eq2", Namespace: "ns2"},
208204
Spec: v1alpha1.ElasticQuotaSpec{
209205
Min: v1.ResourceList{
@@ -276,7 +272,6 @@ func TestCapacityScheduling(t *testing.T) {
276272
},
277273
elasticQuotas: []*v1alpha1.ElasticQuota{
278274
{
279-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
280275
ObjectMeta: metav1.ObjectMeta{Name: "eq1", Namespace: "ns1"},
281276
Spec: v1alpha1.ElasticQuotaSpec{
282277
Min: v1.ResourceList{
@@ -290,7 +285,6 @@ func TestCapacityScheduling(t *testing.T) {
290285
},
291286
},
292287
{
293-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
294288
ObjectMeta: metav1.ObjectMeta{Name: "eq2", Namespace: "ns2"},
295289
Spec: v1alpha1.ElasticQuotaSpec{
296290
Min: v1.ResourceList{
@@ -333,7 +327,6 @@ func TestCapacityScheduling(t *testing.T) {
333327
},
334328
elasticQuotas: []*v1alpha1.ElasticQuota{
335329
{
336-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
337330
ObjectMeta: metav1.ObjectMeta{Name: "eq1", Namespace: "ns1"},
338331
Spec: v1alpha1.ElasticQuotaSpec{
339332
Min: v1.ResourceList{
@@ -347,7 +340,6 @@ func TestCapacityScheduling(t *testing.T) {
347340
},
348341
},
349342
{
350-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
351343
ObjectMeta: metav1.ObjectMeta{Name: "eq2", Namespace: "ns2"},
352344
Spec: v1alpha1.ElasticQuotaSpec{
353345
Min: v1.ResourceList{
@@ -391,7 +383,6 @@ func TestCapacityScheduling(t *testing.T) {
391383
},
392384
elasticQuotas: []*v1alpha1.ElasticQuota{
393385
{
394-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
395386
ObjectMeta: metav1.ObjectMeta{Name: "eq1", Namespace: "ns1"},
396387
Spec: v1alpha1.ElasticQuotaSpec{
397388
Min: v1.ResourceList{
@@ -405,7 +396,6 @@ func TestCapacityScheduling(t *testing.T) {
405396
},
406397
},
407398
{
408-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
409399
ObjectMeta: metav1.ObjectMeta{Name: "eq2", Namespace: "ns2"},
410400
Spec: v1alpha1.ElasticQuotaSpec{
411401
Min: v1.ResourceList{
@@ -453,7 +443,6 @@ func TestCapacityScheduling(t *testing.T) {
453443
},
454444
elasticQuotas: []*v1alpha1.ElasticQuota{
455445
{
456-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
457446
ObjectMeta: metav1.ObjectMeta{Name: "eq1", Namespace: "ns1"},
458447
Spec: v1alpha1.ElasticQuotaSpec{
459448
Min: v1.ResourceList{
@@ -467,7 +456,6 @@ func TestCapacityScheduling(t *testing.T) {
467456
},
468457
},
469458
{
470-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
471459
ObjectMeta: metav1.ObjectMeta{Name: "eq2", Namespace: "ns2"},
472460
Spec: v1alpha1.ElasticQuotaSpec{
473461
Min: v1.ResourceList{
@@ -481,7 +469,6 @@ func TestCapacityScheduling(t *testing.T) {
481469
},
482470
},
483471
{
484-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.sigs.k8s.io/v1alpha1"},
485472
ObjectMeta: metav1.ObjectMeta{Name: "eq3", Namespace: "ns3"},
486473
Spec: v1alpha1.ElasticQuotaSpec{
487474
Min: v1.ResourceList{

test/integration/utils.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ type eqWrapper struct{ *v1alpha1.ElasticQuota }
132132

133133
func MakeEQ(namespace, name string) *eqWrapper {
134134
eq := &v1alpha1.ElasticQuota{
135-
TypeMeta: metav1.TypeMeta{Kind: "ElasticQuota", APIVersion: "scheduling.x-k8s.io/v1alpha1"},
136135
ObjectMeta: metav1.ObjectMeta{
137136
Name: name,
138137
Namespace: namespace,
@@ -296,7 +295,6 @@ type agWrapper struct{ *agv1alpha1.AppGroup }
296295

297296
func MakeAppGroup(namespace, name string) *agWrapper {
298297
ag := &agv1alpha1.AppGroup{
299-
TypeMeta: metav1.TypeMeta{Kind: "AppGroup", APIVersion: "appgroup.diktyo.io/v1alpha1"},
300298
ObjectMeta: metav1.ObjectMeta{
301299
Name: name,
302300
Namespace: namespace,
@@ -334,7 +332,6 @@ type ntWrapper struct{ *ntv1alpha1.NetworkTopology }
334332

335333
func MakeNetworkTopology(namespace, name string) *ntWrapper {
336334
nt := &ntv1alpha1.NetworkTopology{
337-
TypeMeta: metav1.TypeMeta{Kind: "NetworkTopology", APIVersion: "networktopology.diktyo.io/v1alpha1"},
338335
ObjectMeta: metav1.ObjectMeta{
339336
Name: name,
340337
Namespace: namespace,

0 commit comments

Comments
 (0)