Skip to content

Commit 2b09fb6

Browse files
zwpaperHuang-Wei
authored andcommitted
test: fix: add status sub resource to fake clients (#1)
Signed-off-by: Zhang Wei <[email protected]>
1 parent 339ef51 commit 2b09fb6

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

pkg/controllers/elasticquota_controller_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func TestElasticQuotaController_Run(t *testing.T) {
128128
},
129129
want: []*v1alpha1.ElasticQuota{
130130
testutil.MakeEQ("t3-ns1", "t3-eq1").
131-
Used(testutil.MakeResourceList().CPU(0).Mem(0).Obj()).Obj(),
131+
Used(testutil.MakeResourceList().CPU(3).Mem(3).Obj()).Obj(),
132132
testutil.MakeEQ("t3-ns2", "t3-eq2").
133133
Used(testutil.MakeResourceList().CPU(4).Mem(3).Obj()).Obj(),
134134
},
@@ -217,7 +217,7 @@ func TestElasticQuotaController_Run(t *testing.T) {
217217
return false, err
218218
}
219219
if !quota.Equals(eq.Status.Used, v.Status.Used) {
220-
return false, fmt.Errorf("want %v, got %v", v.Status.Used, eq.Status.Used)
220+
return false, fmt.Errorf("%v: want %v, got %v", c.name, v.Status.Used, eq.Status.Used)
221221
}
222222
}
223223
return true, nil
@@ -237,7 +237,10 @@ func setUpEQ(ctx context.Context,
237237
s := scheme.Scheme
238238
utilruntime.Must(v1alpha1.AddToScheme(s))
239239

240-
client := fake.NewClientBuilder().WithScheme(s).Build()
240+
client := fake.NewClientBuilder().
241+
WithScheme(s).
242+
WithStatusSubresource(&v1alpha1.ElasticQuota{}).
243+
Build()
241244
for _, eq := range eqs {
242245
err := client.Create(ctx, eq)
243246
if errors.IsAlreadyExists(err) {

pkg/controllers/podgroup_controller_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,11 @@ func setUp(ctx context.Context,
284284
ps := makePods(podNames, pgName, podPhase, podOwnerReference)
285285
objs = append(objs, ps[0], ps[1])
286286
}
287-
client := fake.NewClientBuilder().WithScheme(s).WithRuntimeObjects(objs...).Build()
287+
client := fake.NewClientBuilder().
288+
WithScheme(s).
289+
WithStatusSubresource(&v1alpha1.PodGroup{}).
290+
WithRuntimeObjects(objs...).
291+
Build()
288292

289293
controller := &PodGroupReconciler{
290294
Client: client,

0 commit comments

Comments
 (0)