Merge pull request #610 from zwpaper/master

k8s-ci-robot · web-flow · commit 32aa038814aa · 2023-08-04T16:58:31.000-07:00
test: fix channel leak in event broadcaster
diff --git a/test/integration/utils.go b/test/integration/utils.go
@@ -197,8 +197,7 @@ func initTestSchedulerWithOptions(t *testing.T, testCtx *testContext, opts ...sc
 		t.Fatalf("Couldn't create scheduler: %v", err)
 	}
 
-	stopCh := make(chan struct{})
-	eventBroadcaster.StartRecordingToSink(stopCh)
+	eventBroadcaster.StartRecordingToSink(testCtx.Ctx.Done())
 
 	return testCtx
 }

Original file line number	Diff line number	Diff line change
`@@ -197,8 +197,7 @@ func initTestSchedulerWithOptions(t testing.T, testCtx testContext, opts ...sc`
`197`	`197`	`t.Fatalf("Couldn't create scheduler: %v", err)`
`198`	`198`	`}`
`199`	`199`
`200`		`- stopCh := make(chan struct{})`
`201`		`- eventBroadcaster.StartRecordingToSink(stopCh)`
	`200`	`+ eventBroadcaster.StartRecordingToSink(testCtx.Ctx.Done())`
`202`	`201`
`203`	`202`	`return testCtx`
`204`	`203`	`}`