fix log print and some nit issue

Author: googs1025

pkg/capacityscheduling/capacity_scheduling.go

@@ -406,7 +406,7 @@ func (p *preemptor) PodEligibleToPreemptOthers(pod *v1.Pod, nominatedNodeStatus
 
 	preFilterState, err := getPreFilterState(p.state)
 	if err != nil {
-		klog.ErrorS(err, "Failed to read preFilterState from cycleState", "preFilterStateKey", preFilterStateKey)
+		klog.V(5).InfoS("Failed to read preFilterState from cycleState, err: %s", err, "preFilterStateKey", preFilterStateKey)
 		return false, "not eligible due to failed to read from cycleState"
 	}
 

pkg/noderesourcetopology/README.md

@@ -262,22 +262,22 @@ zones:
          $ kubectl get noderesourcetopologies.topology.node.k8s.io
        ```
 
-    1. Alternatively, in case you are just interested in simply testing the scheduler plugin, use the manifest in the manifest directory to deploy the CRD and CRs as follows:
+    2. Alternatively, in case you are just interested in simply testing the scheduler plugin, use the manifest in the manifest directory to deploy the CRD and CRs as follows:
 
          1. Deploy the Custom Resource Definition manifest
 
             ```bash
             $ kubectl create -f crd.yaml
             ```
 
-         1. Check if the noderesourcetopologies.topology.node.k8s.io CRD is created
+         2. Check if the noderesourcetopologies.topology.node.k8s.io CRD is created
 
             ```bash
              $ kubectl get crd
              $ kubectl get noderesourcetopologies.topology.node.k8s.io
             ```
 
-         1. Deploy the CRs representative of the hardware topology of the worker-node-A and worker-node-B if CRs haven't been created using RTE or NFD as mentioned above:
+         3. Deploy the CRs representative of the hardware topology of the worker-node-A and worker-node-B if CRs haven't been created using RTE or NFD as mentioned above:
 
             ```bash
              $ kubectl create -f worker-node-A.yaml

pkg/noderesourcetopology/cache/cache.go

@@ -63,7 +63,7 @@ type Interface interface {
 
 	// PostBind is called after a pod is successfully bound. These plugins are
 	// informational. A common application of this extension point is for cleaning
-	// up. If a plugin needs to clean-up its state after a pod is scheduled and
+	// up. If a plugin needs to clean up its state after a pod is scheduled and
 	// bound, PostBind is the extension point that it should register.
 	PostBind(nodeName string, pod *corev1.Pod)
 }

pkg/podstate/pod_state.go

@@ -82,7 +82,7 @@ func (ps *PodState) NormalizeScore(ctx context.Context, state *framework.CycleSt
 		}
 	}
 
-	// Transform the highest to lowest score range to fit the framework's min to max node score range.
+	// Transform the highest to the lowest score range to fit the framework's min to max node score range.
 	oldRange := highest - lowest
 	newRange := framework.MaxNodeScore - framework.MinNodeScore
 	for i, nodeScore := range scores {

pkg/sysched/sysched_test.go

@@ -2,6 +2,7 @@ package sysched
 
 import (
 	"context"
+	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -492,8 +493,7 @@ func TestGetHostSyscalls(t *testing.T) {
 }
 
 func TestUpdateHostSyscalls(t *testing.T) {
-	v1beta1.AddToScheme(clientscheme.Scheme)
-
+	utilruntime.Must(v1beta1.AddToScheme(clientscheme.Scheme))
 	tests := []struct {
 		name     string
 		nodes    []*v1.Node

pkg/trimaran/README.md

@@ -7,7 +7,7 @@ Currently, the collection consists of the following plugins.
 
 - `TargetLoadPacking`: Implements a packing policy up to a configured CPU utilization, then switches to a spreading policy among the hot nodes. (Supports CPU resource.)
 - `LoadVariationRiskBalancing`: Equalizes the risk, defined as a combined measure of average utilization and variation in utilization, among nodes. (Supports CPU and memory resources.)
-- `LowRiskOverCommitment`: Evaluates the performance risk of overcommitment and selects the node with lowest risk by taking into consideration (1) the resource limit values of pods (limit-aware) and (2) the actual load (utilization) on the nodes (load-aware). Thus, it provides a low risk environment for pods and alleviate issues with overcommitment, while allowing pods to use their limits.
+- `LowRiskOverCommitment`: Evaluates the performance risk of overcommitment and selects the node with the lowest risk by taking into consideration (1) the resource limit values of pods (limit-aware) and (2) the actual load (utilization) on the nodes (load-aware). Thus, it provides a low risk environment for pods and alleviate issues with overcommitment, while allowing pods to use their limits.
 
 The Trimaran plugins utilize a [load-watcher](https://github.com/paypal/load-watcher) to access resource utilization data via metrics providers. Currently, the `load-watcher` supports three metrics providers: [Kubernetes Metrics Server](https://github.com/kubernetes-sigs/metrics-server), [Prometheus Server](https://prometheus.io/), and [SignalFx](https://docs.signalfx.com/en/latest/integrations/agent/index.html).
 

pkg/trimaran/lowriskovercommitment/lowriskovercommitment.go

@@ -112,7 +112,7 @@ func (pl *LowRiskOverCommitment) Score(ctx context.Context, cycleState *framewor
 		klog.V(6).InfoS(err.Error()+"; recalculating", "pod", klog.KObj(pod))
 		podResources = CreatePodResourcesStateData(pod)
 	}
-	// exclude scoring for best effort pods; this plugin is not concerned about best effort pods
+	// exclude scoring for best effort pods; this plugin is not concerned about the best effort pods
 	podRequests := &podResources.podRequests
 	podLimits := &podResources.podLimits
 	if podRequests.MilliCPU == 0 && podRequests.Memory == 0 &&

pkg/trimaran/resourcestats.go

@@ -121,7 +121,7 @@ func GetResourceLimits(pod *v1.Pod) *framework.Resource {
 	})
 }
 
-// GetEffectiveResource: calculate effective resources of a pod (CPU and Memory)
+// GetEffectiveResource : calculate effective resources of a pod (CPU and Memory)
 func GetEffectiveResource(pod *v1.Pod, fn func(container *v1.Container) v1.ResourceList) *framework.Resource {
 	result := &framework.Resource{}
 	// add up resources of all containers

pkg/trimaran/targetloadpacking/targetloadpacking.go

@@ -193,13 +193,12 @@ func (pl *TargetLoadPacking) NormalizeScore(context.Context, *framework.CycleSta
 	return nil
 }
 
-// Predict utilization for a container based on its requests/limits
+// PredictUtilisation predict utilization for a container based on its requests/limits
 func PredictUtilisation(container *v1.Container) int64 {
 	if _, ok := container.Resources.Limits[v1.ResourceCPU]; ok {
 		return container.Resources.Limits.Cpu().MilliValue()
 	} else if _, ok := container.Resources.Requests[v1.ResourceCPU]; ok {
 		return int64(math.Round(float64(container.Resources.Requests.Cpu().MilliValue()) * requestsMultiplier))
-	} else {
-		return requestsMilliCores
 	}
+	return requestsMilliCores
 }