Skip to content

Commit 777f67d

Browse files
authored
Merge pull request #654 from kerthcet/cleanup/remove-warning
Add namespace indexer to podInformer
2 parents ca5d17b + fae4102 commit 777f67d

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pkg/coscheduling/coscheduling.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import (
2525
"k8s.io/apimachinery/pkg/labels"
2626
"k8s.io/apimachinery/pkg/runtime"
2727
clientscheme "k8s.io/client-go/kubernetes/scheme"
28+
"k8s.io/client-go/tools/cache"
2829
corev1helpers "k8s.io/component-helpers/scheduling/corev1"
2930
"k8s.io/klog/v2"
3031
"k8s.io/kubernetes/pkg/scheduler/framework"
@@ -74,6 +75,9 @@ func New(obj runtime.Object, handle framework.Handle) (framework.Plugin, error)
7475
return nil, err
7576
}
7677

78+
// Performance improvement when retrieving list of objects by namespace or we'll log 'index not exist' warning.
79+
handle.SharedInformerFactory().Core().V1().Pods().Informer().AddIndexers(cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc})
80+
7781
scheduleTimeDuration := time.Duration(args.PermitWaitingTimeSeconds) * time.Second
7882
pgMgr := core.NewPodGroupManager(
7983
client,
@@ -88,7 +92,7 @@ func New(obj runtime.Object, handle framework.Handle) (framework.Plugin, error)
8892
scheduleTimeout: &scheduleTimeDuration,
8993
}
9094
if args.PodGroupBackoffSeconds < 0 {
91-
err := fmt.Errorf("Parse Arguments Failed")
95+
err := fmt.Errorf("parse arguments failed")
9296
klog.ErrorS(err, "PodGroupBackoffSeconds cannot be negative")
9397
return nil, err
9498
} else if args.PodGroupBackoffSeconds > 0 {

0 commit comments

Comments
 (0)