Skip to content

Commit 8f6ba42

Browse files
authored
Merge pull request #861 from googs1025/flake/fix
flake: fix qos sort plugin flaky integration test
2 parents fd19685 + 1a27c63 commit 8f6ba42

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

test/integration/qos_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,18 +98,22 @@ func TestQOSPlugin(t *testing.T) {
9898
// Make pods[1] Burstable.
9999
pods[1].Spec.Containers[0].Resources = v1.ResourceRequirements{
100100
Requests: v1.ResourceList{
101+
v1.ResourceCPU: *resource.NewMilliQuantity(50, resource.DecimalSI),
101102
v1.ResourceMemory: *resource.NewQuantity(100, resource.DecimalSI),
102103
},
103104
Limits: v1.ResourceList{
105+
v1.ResourceCPU: *resource.NewMilliQuantity(100, resource.DecimalSI),
104106
v1.ResourceMemory: *resource.NewQuantity(200, resource.DecimalSI),
105107
},
106108
}
107109
// Make pods[2] Guaranteed.
108110
pods[2].Spec.Containers[0].Resources = v1.ResourceRequirements{
109111
Requests: v1.ResourceList{
112+
v1.ResourceCPU: *resource.NewMilliQuantity(100, resource.DecimalSI),
110113
v1.ResourceMemory: *resource.NewQuantity(100, resource.DecimalSI),
111114
},
112115
Limits: v1.ResourceList{
116+
v1.ResourceCPU: *resource.NewMilliQuantity(100, resource.DecimalSI),
113117
v1.ResourceMemory: *resource.NewQuantity(100, resource.DecimalSI),
114118
},
115119
}
@@ -161,7 +165,6 @@ func TestQOSPlugin(t *testing.T) {
161165
actualOrder[i] = podInfo.Pod.Name
162166
t.Logf("Popped Pod %q", podInfo.Pod.Name)
163167
}
164-
165168
if !reflect.DeepEqual(actualOrder, expectedOrder) {
166169
t.Errorf("Expected Pod order %v, but got %v", expectedOrder, actualOrder)
167170
} else {

0 commit comments

Comments
 (0)