Skip to content

Commit a1d81a2

Browse files
committed
docs: anyone should be any
Problem: the comment and associated docs should say if there are not resources available needed for the group, the scheduler should not start any. Solution: update all references anyone->any. It could also be stated "not start any one" but "not start any" is a more natural way to say it Signed-off-by: vsoch <[email protected]>
1 parent 2a7767e commit a1d81a2

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

apis/scheduling/v1alpha1/types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,12 @@ type PodGroup struct {
136136
type PodGroupSpec struct {
137137
// MinMember defines the minimal number of members/tasks to run the pod group;
138138
// if there's not enough resources to start all tasks, the scheduler
139-
// will not start anyone.
139+
// will not start any.
140140
MinMember int32 `json:"minMember,omitempty"`
141141

142142
// MinResources defines the minimal resource of members/tasks to run the pod group;
143143
// if there's not enough resources to start all tasks, the scheduler
144-
// will not start anyone.
144+
// will not start any.
145145
MinResources v1.ResourceList `json:"minResources,omitempty"`
146146

147147
// ScheduleTimeoutSeconds defines the maximal time of members/tasks to wait before run the pod group;

config/crd/bases/scheduling.x-k8s.io_podgroups.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ spec:
4242
minMember:
4343
description: MinMember defines the minimal number of members/tasks
4444
to run the pod group; if there's not enough resources to start all
45-
tasks, the scheduler will not start anyone.
45+
tasks, the scheduler will not start any.
4646
format: int32
4747
type: integer
4848
minResources:
@@ -54,7 +54,7 @@ spec:
5454
x-kubernetes-int-or-string: true
5555
description: MinResources defines the minimal resource of members/tasks
5656
to run the pod group; if there's not enough resources to start all
57-
tasks, the scheduler will not start anyone.
57+
tasks, the scheduler will not start any.
5858
type: object
5959
scheduleTimeoutSeconds:
6060
description: ScheduleTimeoutSeconds defines the maximal time of members/tasks

kep/42-podgroup-coscheduling/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ We define a CRD name PodGroup to help schedule, its definition is as follows:
4141
type PodGroupSpec struct {
4242
// MinMember defines the minimal number of members/tasks to run the pod group;
4343
// if there's not enough resources to start all tasks, the scheduler
44-
// will not start anyone.
44+
// will not start any.
4545
MinMember uint32 `json:"minMember"`
4646

4747
// MinResources defines the minimal resource of members/tasks to run the pod group;
4848
// if there's not enough resources to start all tasks, the scheduler
49-
// will not start anyone.
49+
// will not start any.
5050
MinResources *v1.ResourceList `json:"minResources,omitempty"`
5151

5252
// ScheduleTimeoutSeconds defines the maximal time of members/tasks to wait before run the pod group;

manifests/coscheduling/crd.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ spec:
4242
minMember:
4343
description: MinMember defines the minimal number of members/tasks
4444
to run the pod group; if there's not enough resources to start all
45-
tasks, the scheduler will not start anyone.
45+
tasks, the scheduler will not start any.
4646
format: int32
4747
type: integer
4848
minResources:
@@ -54,7 +54,7 @@ spec:
5454
x-kubernetes-int-or-string: true
5555
description: MinResources defines the minimal resource of members/tasks
5656
to run the pod group; if there's not enough resources to start all
57-
tasks, the scheduler will not start anyone.
57+
tasks, the scheduler will not start any.
5858
type: object
5959
scheduleTimeoutSeconds:
6060
description: ScheduleTimeoutSeconds defines the maximal time of members/tasks

site/content/en/docs/kep/42-podgroup-coscheduling/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ We define a CRD name PodGroup to help schedule, its definition is as follows:
4545
type PodGroupSpec struct {
4646
// MinMember defines the minimal number of members/tasks to run the pod group;
4747
// if there's not enough resources to start all tasks, the scheduler
48-
// will not start anyone.
48+
// will not start any.
4949
MinMember uint32 `json:"minMember"`
5050

5151
// MinResources defines the minimal resource of members/tasks to run the pod group;
5252
// if there's not enough resources to start all tasks, the scheduler
53-
// will not start anyone.
53+
// will not start any.
5454
MinResources *v1.ResourceList `json:"minResources,omitempty"`
5555

5656
// ScheduleTimeoutSeconds defines the maximal time of members/tasks to wait before run the pod group;

0 commit comments

Comments
 (0)