Skip to content

Commit a3f93ab

Browse files
committed
test: integration: nrt: use unique pod names
To eliminate any possible confusion, both for humans troubleshooting, and for machines (avoid possible races, even though the tests are running serially) running, let's use unique pod names. Signed-off-by: Francesco Romani <[email protected]>
1 parent c35e929 commit a3f93ab

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

test/integration/noderesourcetopology_cache_test.go

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
105105
name: "BU pod: pessimistic cache overallocation not impactful, pod to be scheduled",
106106
podDescs: []podDesc{
107107
{
108-
podName: "nrt-bu-pod-1000",
108+
podName: "nrt-bu-overalloc-1000",
109109
isGuaranteed: false,
110110
resourcesMap: map[string]string{
111111
string(corev1.ResourceCPU): "16",
@@ -114,7 +114,7 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
114114
expectedNode: anyNode,
115115
},
116116
{
117-
podName: "nrt-bu-pod-2000",
117+
podName: "nrt-bu-overalloc-2000",
118118
isGuaranteed: false,
119119
resourcesMap: map[string]string{
120120
string(corev1.ResourceCPU): "16",
@@ -172,15 +172,15 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
172172
name: "BE pod: with devices, pessimistic cache overallocation prevents pod to be scheduled",
173173
podDescs: []podDesc{
174174
{
175-
podName: "nrt-be-pod-3000",
175+
podName: "nrt-be-overalloc-3000",
176176
isGuaranteed: true, // aka set resourcesMap in limits
177177
resourcesMap: map[string]string{
178178
nicResourceName: "2",
179179
},
180180
expectedNode: "fake-node-cache-2",
181181
},
182182
{
183-
podName: "nrt-be-pod-4000",
183+
podName: "nrt-be-overalloc-4000",
184184
isGuaranteed: true, // aka set resourcesMap in limits
185185
resourcesMap: map[string]string{
186186
nicResourceName: "2",
@@ -194,7 +194,7 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
194194
name: "GU pod: pessimistic cache overallocation prevents pod to be scheduled",
195195
podDescs: []podDesc{
196196
{
197-
podName: "nrt-pod-1000",
197+
podName: "nrt-gu-overalloc-1000",
198198
isGuaranteed: true,
199199
resourcesMap: map[string]string{
200200
string(corev1.ResourceCPU): "16",
@@ -203,7 +203,7 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
203203
expectedNode: "fake-node-cache-1",
204204
},
205205
{
206-
podName: "nrt-pod-2000",
206+
podName: "nrt-gu-overalloc-2000",
207207
isGuaranteed: true,
208208
resourcesMap: map[string]string{
209209
string(corev1.ResourceCPU): "16",
@@ -261,7 +261,7 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
261261
name: "GU pod: pessimistic cache overallocation ignores deletes prevents pod to be scheduled",
262262
podDescs: []podDesc{
263263
{
264-
podName: "nrt-pod-3000",
264+
podName: "nrt-gu-overalloc-del-3000",
265265
isGuaranteed: true,
266266
resourcesMap: map[string]string{
267267
string(corev1.ResourceCPU): "16",
@@ -270,11 +270,11 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
270270
expectedNode: "fake-node-cache-1",
271271
},
272272
{
273-
podName: "nrt-pod-3000",
273+
podName: "nrt-gu-overalloc-del-3000",
274274
isDelete: true,
275275
},
276276
{
277-
podName: "nrt-pod-4000",
277+
podName: "nrt-gu-overalloc-del-4000",
278278
isGuaranteed: true,
279279
resourcesMap: map[string]string{
280280
string(corev1.ResourceCPU): "16",
@@ -332,7 +332,7 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
332332
name: "GU pod: DiscardReservedNodes: allows scheduling on both Zones",
333333
podDescs: []podDesc{
334334
{
335-
podName: "nrt-pod-1000",
335+
podName: "nrt-gu-discardresv-1000",
336336
isGuaranteed: true,
337337
resourcesMap: map[string]string{
338338
string(corev1.ResourceCPU): "16",
@@ -342,7 +342,7 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
342342
expectedNode: "fake-node-cache-1",
343343
},
344344
{
345-
podName: "nrt-pod-2000",
345+
podName: "nrt-gu-discardresv-2000",
346346
isGuaranteed: true,
347347
resourcesMap: map[string]string{
348348
string(corev1.ResourceCPU): "16",
@@ -401,7 +401,7 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
401401
name: "GU pod: DiscardReservedNodes: new pod is successfully scheduled on the node, after deleting pod consuming most resources",
402402
podDescs: []podDesc{
403403
{
404-
podName: "nrt-pod-3000",
404+
podName: "nrt-gu-discardresv-ok-3000",
405405
isGuaranteed: true,
406406
resourcesMap: map[string]string{
407407
string(corev1.ResourceCPU): "30",
@@ -411,12 +411,12 @@ func TestTopologyCachePluginWithoutUpdates(t *testing.T) {
411411
expectedNode: "fake-node-cache-1",
412412
},
413413
{
414-
podName: "nrt-pod-3000",
414+
podName: "nrt-gu-discardresv-ok-3000",
415415
isDelete: true,
416416
schedulerName: "discardReserved",
417417
},
418418
{
419-
podName: "nrt-pod-4000",
419+
podName: "nrt-gu-discardresv-ok-4000",
420420
isGuaranteed: true,
421421
resourcesMap: map[string]string{
422422
string(corev1.ResourceCPU): "16",

0 commit comments

Comments
 (0)