nrt: cache: discardreserved: fix return value

The caches are authoritative regarding the freshness of
the data they return. This is the intended meaning of the
boolean return value in the GetCachedNRTCopy signature, kinda
like "isValid" or "isFresh". So, when there's no data in
the cache, the information *IS* fresh and should be reported as such.

The cached data is expected to be out of data ("stale", "not fresh",
"invalid") only when foreign pods (pods running on a node managed
by the scheduler, but not scheduled by this scheduler) are detected,
and even so, some cache implementations may tolerate this condition
and still report valid data.

Signed-off-by: Francesco Romani <[email protected]>

Author: ffromani

pkg/noderesourcetopology/cache/discardreserved.go

@@ -65,7 +65,7 @@ func (pt *DiscardReserved) GetCachedNRTCopy(ctx context.Context, nodeName string
 
 	nrt := &topologyv1alpha2.NodeResourceTopology{}
 	if err := pt.client.Get(ctx, types.NamespacedName{Name: nodeName}, nrt); err != nil {
-		return nil, false
+		return nil, true
 	}
 	return nrt, true
 }