Skip to content

Commit acc9296

Browse files
committed
Optimized error formatting and usestdlibvars
Signed-off-by: Fish-pro <[email protected]>
1 parent ca2ca69 commit acc9296

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

cmd/scheduler/main_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func TestSetup(t *testing.T) {
5757
// https server
5858
server := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
5959
w.Header().Set("Content-Type", "application/json")
60-
w.WriteHeader(200)
60+
w.WriteHeader(http.StatusOK)
6161
w.Write([]byte(`{"metadata": {"name": "test"}}`))
6262
}))
6363
defer server.Close()

pkg/capacityscheduling/capacity_scheduling.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -765,7 +765,7 @@ func getPreFilterState(cycleState *framework.CycleState) (*PreFilterState, error
765765
c, err := cycleState.Read(preFilterStateKey)
766766
if err != nil {
767767
// preFilterState doesn't exist, likely PreFilter wasn't invoked.
768-
return nil, fmt.Errorf("error reading %q from cycleState: %v", preFilterStateKey, err)
768+
return nil, fmt.Errorf("error reading %q from cycleState: %w", preFilterStateKey, err)
769769
}
770770

771771
s, ok := c.(*PreFilterState)
@@ -779,7 +779,7 @@ func getElasticQuotaSnapshotState(cycleState *framework.CycleState) (*ElasticQuo
779779
c, err := cycleState.Read(ElasticQuotaSnapshotKey)
780780
if err != nil {
781781
// ElasticQuotaSnapshotState doesn't exist, likely PreFilter wasn't invoked.
782-
return nil, fmt.Errorf("error reading %q from cycleState: %v", ElasticQuotaSnapshotKey, err)
782+
return nil, fmt.Errorf("error reading %q from cycleState: %w", ElasticQuotaSnapshotKey, err)
783783
}
784784

785785
s, ok := c.(*ElasticQuotaSnapshotState)

pkg/coscheduling/core/core.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ func (pgMgr *PodGroupManager) PreFilter(ctx context.Context, pod *corev1.Pod) er
147147
labels.SelectorFromSet(labels.Set{v1alpha1.PodGroupLabel: util.GetPodGroupLabel(pod)}),
148148
)
149149
if err != nil {
150-
return fmt.Errorf("podLister list pods failed: %v", err)
150+
return fmt.Errorf("podLister list pods failed: %w", err)
151151
}
152152
if len(pods) < int(pg.Spec.MinMember) {
153153
return fmt.Errorf("pre-filter pod %v cannot find enough sibling pods, "+

pkg/networkaware/networkoverhead/networkoverhead.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,7 +602,7 @@ func getPreFilterState(cycleState *framework.CycleState) (*PreFilterState, error
602602
no, err := cycleState.Read(preFilterStateKey)
603603
if err != nil {
604604
// preFilterState doesn't exist, likely PreFilter wasn't invoked.
605-
return nil, fmt.Errorf("error reading %q from cycleState: %v", preFilterStateKey, err)
605+
return nil, fmt.Errorf("error reading %q from cycleState: %w", preFilterStateKey, err)
606606
}
607607

608608
state, ok := no.(*PreFilterState)

0 commit comments

Comments
 (0)