nrt: fix handling of ephemeral-storage requests

Add ephemeral-storage to the special-case handling for resources which
lack NUMA affinity.

Signed-off-by: Phil Sphicas <[email protected]>

Author: philsphicas

pkg/noderesourcetopology/filter.go

@@ -131,7 +131,9 @@ func resourcesAvailableInAnyNUMANodes(logID string, numaNodes NUMANodeList, reso
 			klog.V(6).InfoS("feasible", "logID", logID, "node", nodeName, "NUMA", numaNode.NUMAID, "resource", resource)
 		}
 
-		if !hasNUMAAffinity && !v1helper.IsNativeResource(resource) {
+		// non-native resources or ephemeral-storage may not expose NUMA affinity,
+		// but since they are available at node level, this is fine
+		if !hasNUMAAffinity && (!v1helper.IsNativeResource(resource) || resource == v1.ResourceEphemeralStorage) {
 			klog.V(6).InfoS("resource available at node level (no NUMA affinity)", "logID", logID, "node", nodeName, "resource", resource)
 			continue
 		}

pkg/noderesourcetopology/filter_test.go

@@ -661,6 +661,16 @@ func TestNodeResourceTopology(t *testing.T) {
 			node:       nodes[1],
 			wantStatus: nil,
 		},
+		{
+			name: "Guaranteed QoS, ephemeral-storage (non-NUMA), pod fit",
+			pod: makePodByResourceList(&v1.ResourceList{
+				v1.ResourceCPU:              *resource.NewQuantity(2, resource.DecimalSI),
+				v1.ResourceMemory:           resource.MustParse("2Gi"),
+				v1.ResourceEphemeralStorage: resource.MustParse("100Mi"),
+			}),
+			node:       nodes[1],
+			wantStatus: nil,
+		},
 	}
 
 	fakeClient := faketopologyv1alpha2.NewSimpleClientset()