Skip to content

Commit d4204aa

Browse files
authored
Merge pull request #777 from Huang-Wei/fix-build
2 parents 372fafd + 832645d commit d4204aa

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

Makefile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ build: build-controller build-scheduler
5151

5252
.PHONY: build-controller
5353
build-controller:
54-
go build -ldflags '-w' -o bin/controller cmd/controller/controller.go
54+
$(GO_BUILD_ENV) go build -ldflags '-X k8s.io/component-base/version.gitVersion=$(VERSION) -w' -o bin/controller cmd/controller/controller.go
5555

5656
.PHONY: build-scheduler
5757
build-scheduler:
58-
go build -ldflags '-X k8s.io/component-base/version.gitVersion=$(VERSION) -w' -o bin/kube-scheduler cmd/scheduler/main.go
58+
$(GO_BUILD_ENV) go build -ldflags '-X k8s.io/component-base/version.gitVersion=$(VERSION) -w' -o bin/kube-scheduler cmd/scheduler/main.go
5959

6060
.PHONY: build-images
6161
build-images:
@@ -73,8 +73,6 @@ build-images:
7373
.PHONY: local-image
7474
local-image: PLATFORMS="linux/$$(uname -m)"
7575
local-image: RELEASE_VERSION="v0.0.0"
76-
local-image: IMAGE="kube-scheduler:latest"
77-
local-image: CONTROLLER_IMAGE="controller:latest"
7876
local-image: REGISTRY="localhost:5000/scheduler-plugins"
7977
local-image: EXTRA_ARGS="--load"
8078
local-image: clean build-images

build/controller/Dockerfile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,17 @@
1313
# limitations under the License.
1414
ARG GO_BASE_IMAGE
1515
ARG DISTROLESS_BASE_IMAGE=gcr.io/distroless/static:nonroot
16-
FROM --platform=${BUILDPLATFORM} $GO_BASE_IMAGE as go_builder
16+
FROM --platform=${BUILDPLATFORM} $GO_BASE_IMAGE as builder
1717

18-
WORKDIR /go/src/sigs.k8s.io/scheduler-plugins
18+
WORKDIR /workspace
1919
COPY . .
2020
ARG TARGETARCH
2121
RUN make build-controller GO_BUILD_ENV='CGO_ENABLED=0 GOOS=linux GOARCH=${TARGETARCH}'
2222

2323
FROM --platform=${BUILDPLATFORM} $DISTROLESS_BASE_IMAGE
2424

25-
COPY --from=go_builder /go/src/sigs.k8s.io/scheduler-plugins/bin/controller /bin/controller
25+
WORKDIR /
26+
COPY --from=builder /workspace/bin/controller .
27+
USER 65532:65532
2628

27-
WORKDIR /bin
28-
CMD ["controller"]
29+
ENTRYPOINT ["/controller"]

build/scheduler/Dockerfile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,17 @@
1313
# limitations under the License.
1414
ARG GO_BASE_IMAGE
1515
ARG DISTROLESS_BASE_IMAGE=gcr.io/distroless/static:nonroot
16-
FROM --platform=${BUILDPLATFORM} $GO_BASE_IMAGE as go-builder
16+
FROM --platform=${BUILDPLATFORM} $GO_BASE_IMAGE as builder
1717

18-
WORKDIR /go/src/sigs.k8s.io/scheduler-plugins
18+
WORKDIR /workspace
1919
COPY . .
2020
ARG TARGETARCH
2121
RUN make build-scheduler GO_BUILD_ENV='CGO_ENABLED=0 GOOS=linux GOARCH=${TARGETARCH}'
2222

2323
FROM --platform=${BUILDPLATFORM} $DISTROLESS_BASE_IMAGE
2424

25-
COPY --from=go-builder /go/src/sigs.k8s.io/scheduler-plugins/bin/kube-scheduler /bin/kube-scheduler
25+
WORKDIR /
26+
COPY --from=builder /workspace/bin/kube-scheduler .
27+
USER 65532:65532
2628

27-
WORKDIR /bin
28-
CMD ["kube-scheduler"]
29+
ENTRYPOINT ["/kube-scheduler"]

0 commit comments

Comments
 (0)