Skip to content

Commit f728822

Browse files
committed
fix lowriskovercommitment
1 parent e008f38 commit f728822

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

pkg/trimaran/lowriskovercommitment/lowriskovercommitment.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,9 @@ func (pl *LowRiskOverCommitment) PreScore(ctx context.Context, cycleState *frame
101101
}
102102

103103
// Score : evaluate score for a node
104-
func (pl *LowRiskOverCommitment) Score(ctx context.Context, cycleState *framework.CycleState, pod *v1.Pod, nodeName string) (int64, *framework.Status) {
104+
func (pl *LowRiskOverCommitment) Score(ctx context.Context, cycleState *framework.CycleState, pod *v1.Pod, nodeInfo *framework.NodeInfo) (int64, *framework.Status) {
105105
logger := klog.FromContext(klog.NewContext(ctx, pl.logger)).WithValues("ExtensionPoint", "Score")
106+
nodeName := nodeInfo.Node().Name
106107
logger.V(6).Info("Score: Calculating score", "pod", klog.KObj(pod), "nodeName", nodeName)
107108
score := framework.MinNodeScore
108109

@@ -125,11 +126,6 @@ func (pl *LowRiskOverCommitment) Score(ctx context.Context, cycleState *framewor
125126
logger.V(6).Info("Skipping scoring best effort pod; using minimum score", "nodeName", nodeName, "pod", klog.KObj(pod))
126127
return score, nil
127128
}
128-
// get node info
129-
nodeInfo, err := pl.handle.SnapshotSharedLister().NodeInfos().Get(nodeName)
130-
if err != nil {
131-
return score, framework.NewStatus(framework.Error, fmt.Sprintf("getting node %q from Snapshot: %v", nodeName, err))
132-
}
133129
// get node metrics
134130
metrics, _ := pl.collector.GetNodeMetrics(logger, nodeName)
135131
if metrics == nil {

0 commit comments

Comments
 (0)