Add logs for secret update.

Author: dargudear-google

controllers/secretproviderclasspodstatus_controller.go

@@ -418,9 +418,11 @@ func (r *SecretProviderClassPodStatusReconciler) createOrUpdateK8sSecret(ctx con
 	if apierrors.IsAlreadyExists(err) {
 		klog.InfoS("Secret is already there", "secret", klog.ObjectRef{Namespace: namespace, Name: name})
 		err := r.writer.Update(ctx, secret)
-		if err == nil {
+		if err != nil {
 			klog.Errorf("Unable to update secret", "secret", klog.ObjectRef{Namespace: namespace, Name: name})
 			return err
+		} else {
+			klog.InfoS("successfully updated Kubernetes secret", "secret", klog.ObjectRef{Namespace: namespace, Name: name})
 		}
 		return nil
 	}

controllers/secretproviderclasspodstatus_controller_test.go

@@ -173,7 +173,7 @@ func TestCreateOrUpdateK8sSecret(t *testing.T) {
 	client := fake.NewClientBuilder().WithScheme(scheme).WithObjects(initObjects...).Build()
 	reconciler := newReconciler(client, scheme, "node1")
 
-	// secret already exists
+	// secret already exists, just update it.
 	err = reconciler.createOrUpdateK8sSecret(context.TODO(), "my-secret", "default", nil, labels, annotations, corev1.SecretTypeOpaque)
 	g.Expect(err).NotTo(HaveOccurred())
 

test/bats/e2e-provider.bats

@@ -431,7 +431,7 @@ export VALIDATE_TOKENS_AUDIENCE=$(get_token_requests_audience)
   kubectl create ns metrics
   local curl_pod_name=curl-$(openssl rand -hex 5)
   kubectl run ${curl_pod_name} -n metrics --image=curlimages/curl:7.75.0 --labels="test=metrics" -- tail -f /dev/null
-  kubectl wait -n metrics --for=condition=Ready --timeout=60s pod ${curl_pod_name}
+  kubectl wait -n metrics --for=condition=Ready --timeout=120s pod ${curl_pod_name}
   for pod_ip in $(kubectl get pod -n kube-system -l app=secrets-store-csi-driver -o jsonpath="{.items[0].status.podIP}")
   do
     run kubectl exec ${curl_pod_name} -n metrics -- curl http://${pod_ip}:8095/metrics