Skip to content

Commit 11d9bfa

Browse files
committed
Change operation test dependency on parseableType rather than typename
1 parent 8a2620f commit 11d9bfa

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

merge/real_test.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func read(file string) []byte {
3737
return s
3838
}
3939

40-
var parser = func() Parser {
40+
var k8s = func() Parser {
4141
s := read(testdata("k8s-schema.yaml"))
4242
parser, err := typed.NewParser(typed.YAMLObject(s))
4343
if err != nil {
@@ -48,24 +48,24 @@ var parser = func() Parser {
4848

4949
func BenchmarkOperations(b *testing.B) {
5050
benches := []struct {
51-
typename string
52-
filename string
51+
parseType typed.ParseableType
52+
filename string
5353
}{
5454
{
55-
typename: "io.k8s.api.core.v1.Pod",
56-
filename: "pod.yaml",
55+
parseType: k8s.Type("io.k8s.api.core.v1.Pod"),
56+
filename: "pod.yaml",
5757
},
5858
{
59-
typename: "io.k8s.api.core.v1.Node",
60-
filename: "node.yaml",
59+
parseType: k8s.Type("io.k8s.api.core.v1.Node"),
60+
filename: "node.yaml",
6161
},
6262
{
63-
typename: "io.k8s.api.core.v1.Endpoints",
64-
filename: "endpoints.yaml",
63+
parseType: k8s.Type("io.k8s.api.core.v1.Endpoints"),
64+
filename: "endpoints.yaml",
6565
},
6666
{
67-
typename: "io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1beta1.CustomResourceDefinition",
68-
filename: "prometheus-crd.yaml",
67+
parseType: k8s.Type("io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1beta1.CustomResourceDefinition"),
68+
filename: "prometheus-crd.yaml",
6969
},
7070
}
7171

@@ -147,7 +147,7 @@ func BenchmarkOperations(b *testing.B) {
147147
tc := TestCase{
148148
Ops: test.ops,
149149
}
150-
p := SameVersionParser{T: parser.Type(bench.typename)}
150+
p := SameVersionParser{T: bench.parseType}
151151
tc.PreprocessOperations(p)
152152

153153
b.ReportAllocs()

0 commit comments

Comments
 (0)