Skip to content

Commit 6a44ab7

Browse files
author
Antoine Pelisse
committed
Fix bug in NormalizedUnions
1 parent b2ed7e1 commit 6a44ab7

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

typed/typed.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,16 +159,15 @@ func (tv TypedValue) RemoveItems(items *fieldpath.Set) *TypedValue {
159159
func (tv TypedValue) NormalizeUnions(new *TypedValue) (*TypedValue, error) {
160160
var errs ValidationErrors
161161
var normalizeFn = func(w *mergingWalker) {
162-
if err := normalizeUnion(w); err != nil {
163-
errs = append(errs, w.error(err)...)
164-
}
165-
}
166-
out, mergeErrs := merge(&tv, new, func(w *mergingWalker) {
167162
if w.rhs != nil {
168163
v := *w.rhs
169164
w.out = &v
170165
}
171-
}, normalizeFn)
166+
if err := normalizeUnion(w); err != nil {
167+
errs = append(errs, w.error(err)...)
168+
}
169+
}
170+
out, mergeErrs := merge(&tv, new, func(w *mergingWalker) {}, normalizeFn)
172171
if mergeErrs != nil {
173172
errs = append(errs, mergeErrs.(ValidationErrors)...)
174173
}

0 commit comments

Comments
 (0)