Merge pull request #1227 from bryan-lou/bryanlou-dev-1

Add tests and stories for dashboard tab test failure alert/health summary

Author: google-oss-prow[bot]

web/src/testgrid-dashboard-summary.ts

@@ -19,40 +19,40 @@ export interface TabSummaryInfo {
   healthinessSummary?: HealthinessSummaryInfo;
 }
 
-interface FailuresSummaryInfo {
+export interface FailuresSummaryInfo {
   topFailingTests: FailingTestInfo[];
   failureStats: FailureStats;
 }
 
-interface FailingTestInfo {
+export interface FailingTestInfo {
   displayName: string;
   failCount: number;
   passTimestamp: string;
   failTimestamp: string;
-  healthinessSummary?: HealthinessSummaryInfo;
 }
 
-interface HealthinessSummaryInfo {
+export interface FailureStats {
+  numFailingTests: number;
+}
+
+export interface HealthinessSummaryInfo {
   topFlakyTests: FlakyTestInfo[];
   healthinessStats: HealthinessStats;
 }
 
-interface FlakyTestInfo {
+export interface FlakyTestInfo {
   displayName: string;
   flakiness: number;
 }
 
-interface HealthinessStats {
+export interface HealthinessStats {
   startTimestamp: string;
   endTimestamp: string;
   numFlakyTests: number;
   averageFlakiness: number;
   previousFlakiness: number;
 }
 
-interface FailureStats {
-  numFailingTests: number;
-}
 // TODO: define in a shared file (dashboard group also uses this)
 export const TabStatusIcon = new Map<string, string>([
   ['PASSING', 'done'],

web/stories/tab-summary.stories.ts

@@ -1,6 +1,6 @@
 import { html, TemplateResult } from 'lit';
 import '../src/tab-summary.js';
-import { TabSummaryInfo } from '../src/testgrid-dashboard-summary';
+import { FailingTestInfo, FailuresSummaryInfo, FailureStats, FlakyTestInfo, HealthinessStats, HealthinessSummaryInfo, TabSummaryInfo } from '../src/testgrid-dashboard-summary';
 
 export default {
   title: 'Tab summary',
@@ -21,6 +21,36 @@ const Template: Story<Args> = ({
   icon = 'done',
   overallStatus = 'PASSING',
 }: Args) => {
+  const failuresSummary = {} as FailuresSummaryInfo
+  const failureStats: FailureStats = {
+    numFailingTests: 1
+  }
+  const FailingTest = {
+    displayName: "TEST0",
+    failCount: 1,
+    passTimestamp: "today",
+    failTimestamp: "today",
+  } as FailingTestInfo
+
+  failuresSummary.failureStats = failureStats
+  failuresSummary.topFailingTests = [FailingTest];
+
+  const healthinessSummary = {} as HealthinessSummaryInfo
+  const healthinessStats: HealthinessStats = {
+    startTimestamp: "today",
+    endTimestamp: "today",
+    numFlakyTests: 1,
+    averageFlakiness: 0,
+    previousFlakiness: 100,
+  }
+  const FlakyTest = {
+    displayName: "TEST1",
+    flakiness: 0,
+  } as FlakyTestInfo
+
+  healthinessSummary.healthinessStats = healthinessStats
+  healthinessSummary.topFlakyTests = [FlakyTest]
+
   const tsi: TabSummaryInfo = {
     icon,
     name: 'TEST',
@@ -30,6 +60,8 @@ const Template: Story<Args> = ({
     lastUpdateTimestamp: 'today',
     latestGreenBuild: 'HULK!',
     dashboardName: 'TEST1',
+    failuresSummary: failuresSummary,
+    healthinessSummary: healthinessSummary,
   };
 
   return html`<link

web/test/testgrid-dashboard-summary.test.ts

@@ -33,5 +33,13 @@ describe('Testgrid Dashboard Summary page', () => {
     );
 
     expect(element.tabSummariesInfo.length).to.equal(4);
+    expect(element.tabSummariesInfo[0].name).to.equal("fake-tab-1");
+    expect(element.tabSummariesInfo[0].overallStatus).to.equal("PASSING");
+    expect(element.tabSummariesInfo[0].failuresSummary?.failureStats.numFailingTests).to.equal(1);
+    expect(element.tabSummariesInfo[0].failuresSummary?.topFailingTests[0].failCount).to.equal(1);
+    expect(element.tabSummariesInfo[0].failuresSummary?.topFailingTests[0].displayName).to.equal("fake-test-1");
+    expect(element.tabSummariesInfo[0].healthinessSummary?.topFlakyTests[0].displayName).to.equal("fake-test-2");
+    expect(element.tabSummariesInfo[0].healthinessSummary?.topFlakyTests[0].flakiness).to.equal(2);
+    expect(element.tabSummariesInfo[0].healthinessSummary?.healthinessStats.numFlakyTests).to.equal(2);
   });
 });