Test addition (#3379)

Author: bn023052

tests/e2e/csi_cns_telemetry.go

@@ -276,4 +276,61 @@ var _ = ginkgo.Describe("[csi-block-vanilla] [csi-file-vanilla] [csi-block-vanil
 			gomega.Equal(vanillaClusterDistributionWithSpecialChar),
 			"Wrong/empty cluster-distribution name present on CNS")
 	})
+
+	// Test to verify PVC goes to Pending when cluster-distribution name has more than 128 characters
+	// Steps
+	// 1. Update cluster-distribution value to  more than 128 characters
+	// 2. Create a PVC.
+	// 3. Expect PVC to go to Pending state.
+
+	ginkgo.It("Verify PVC goes to Pending when cluster distribution name has more than 128 characters", ginkgo.Label(p0,
+		block, file, vanilla, vc70), func() {
+		ctx, cancel := context.WithCancel(context.Background())
+		defer cancel()
+
+		var pvclaim *v1.PersistentVolumeClaim
+		var storageclasspvc *storagev1.StorageClass
+		var err error
+
+		ginkgo.By("Setting the cluster-distribution name having more than 128 characters")
+		clsDistributionName, err := genrateRandomString(130)
+		gomega.Expect(err).NotTo(gomega.HaveOccurred())
+		setClusterDistribution(ctx, client, clsDistributionName)
+		ginkgo.By("Restart CSI driver")
+		collectPodLogs(ctx, client, csiSystemNamespace)
+		restartSuccess, err := restartCSIDriver(ctx, client, csiNamespace, csiReplicas)
+		gomega.Expect(restartSuccess).To(gomega.BeTrue(), "csi driver restart not successful")
+		gomega.Expect(err).NotTo(gomega.HaveOccurred())
+
+		defer func() {
+			// Reset the cluster distribution value to default value "CSI-Vanilla".
+			setClusterDistribution(ctx, client, vanillaClusterDistribution)
+		}()
+
+		ginkgo.By("Creating a PVC")
+		scParameters[scParamDatastoreURL] = datastoreURL
+		storageclasspvc, pvclaim, err = createPVCAndStorageClass(ctx, client,
+			namespace, nil, scParameters, diskSize, nil, "", false, "")
+		gomega.Expect(err).NotTo(gomega.HaveOccurred())
+
+		defer func() {
+			err = fpv.DeletePersistentVolumeClaim(ctx, client, pvclaim.Name, pvclaim.Namespace)
+			gomega.Expect(err).NotTo(gomega.HaveOccurred())
+
+			err := client.StorageV1().StorageClasses().Delete(ctx,
+				storageclasspvc.Name, *metav1.NewDeleteOptions(0))
+			gomega.Expect(err).NotTo(gomega.HaveOccurred())
+		}()
+
+		ginkgo.By("Expect claim to fail")
+		err = fpv.WaitForPersistentVolumeClaimPhase(ctx,
+			v1.ClaimPending, client, pvclaim.Namespace, pvclaim.Name, framework.Poll, time.Second*130)
+		gomega.Expect(err).NotTo(gomega.HaveOccurred())
+
+		expectedErrMsg := "A specified parameter was not correct: createSpecs.metadata.containerCluster.clusterDistribution"
+		framework.Logf("Expected failure message: %+q", expectedErrMsg)
+		errorOccurred := checkEventsforError(client, pvclaim.Namespace,
+			metav1.ListOptions{FieldSelector: fmt.Sprintf("involvedObject.name=%s", pvclaim.Name)}, expectedErrMsg)
+		gomega.Expect(errorOccurred).To(gomega.BeTrue())
+	})
 })

tests/e2e/util.go

@@ -19,6 +19,7 @@ package e2e
 import (
 	"bytes"
 	"context"
+	cryptoRand "crypto/rand"
 	"crypto/tls"
 	"encoding/json"
 	"errors"
@@ -8129,3 +8130,16 @@ func createtWcpNsWithZonesAndPolicies(
 
 	return namespace, statusCode, nil
 }
+
+// Generates random string of requested length
+func genrateRandomString(length int) (string, error) {
+	var generatedString string
+	rand.New(rand.NewSource(time.Now().UnixNano()))
+	b := make([]byte, length+2)
+	_, err := cryptoRand.Read(b)
+	if err != nil {
+		return generatedString, fmt.Errorf("error marshalling request body: %w", err)
+	}
+	generatedString = fmt.Sprintf("%x", b)[2 : length+2]
+	return generatedString, err
+}