Skip to content

Commit 9705c6b

Browse files
Adjusted timing and resolving test issue in topology and static volume provisioning testcases (#3383)
1 parent 7651843 commit 9705c6b

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

tests/e2e/csi_static_provisioning_basic.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2422,9 +2422,11 @@ var _ = ginkgo.Describe("Basic Static Provisioning", func() {
24222422
masterIP = GetAndExpectStringEnvVar(svcMasterIP)
24232423
}
24242424

2425+
datastoreName, _, err := e2eVSphere.fetchDatastoreNameFromDatastoreUrl(ctx, fcdID)
2426+
gomega.Expect(err).NotTo(gomega.HaveOccurred())
24252427
framework.Logf("Get vmdk path from volume handle")
24262428
if vanillaCluster {
2427-
vmdk = getVmdkPathFromVolumeHandle(sshClientConfig, masterIP, defaultDatastore.Name(), pv.Spec.CSI.VolumeHandle)
2429+
vmdk = getVmdkPathFromVolumeHandle(sshClientConfig, masterIP, datastoreName, pv.Spec.CSI.VolumeHandle)
24282430
}
24292431
esxHost := GetAndExpectStringEnvVar(envEsxHostIP)
24302432
ginkgo.By("Delete the vmdk file associasted with the above FCD")

tests/e2e/topology_multi_replica.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,7 @@ var _ = ginkgo.Describe("[topology-multireplica] Topology-MultiReplica",
846846
pv := getPvFromClaim(client, pvclaimsList[i].Namespace, pvclaimsList[i].Name)
847847
err = fpv.DeletePersistentVolumeClaim(ctx, client, pvclaimsList[i].Name, namespace)
848848
gomega.Expect(err).NotTo(gomega.HaveOccurred())
849-
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, pollTimeoutShort))
849+
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, framework.PodDeleteTimeout))
850850
err = e2eVSphere.waitForCNSVolumeToBeDeleted(pv.Spec.CSI.VolumeHandle)
851851
gomega.Expect(err).NotTo(gomega.HaveOccurred())
852852
}
@@ -1103,7 +1103,7 @@ var _ = ginkgo.Describe("[topology-multireplica] Topology-MultiReplica",
11031103
pv := getPvFromClaim(client, pvclaimsList[i].Namespace, pvclaimsList[i].Name)
11041104
err = fpv.DeletePersistentVolumeClaim(ctx, client, pvclaimsList[i].Name, namespace)
11051105
gomega.Expect(err).NotTo(gomega.HaveOccurred())
1106-
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, pollTimeoutShort))
1106+
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, framework.PodDeleteTimeout))
11071107
err = e2eVSphere.waitForCNSVolumeToBeDeleted(pv.Spec.CSI.VolumeHandle)
11081108
gomega.Expect(err).NotTo(gomega.HaveOccurred())
11091109
}
@@ -1632,7 +1632,7 @@ var _ = ginkgo.Describe("[topology-multireplica] Topology-MultiReplica",
16321632
pv := getPvFromClaim(client, pvclaimsList[i].Namespace, pvclaimsList[i].Name)
16331633
err = fpv.DeletePersistentVolumeClaim(ctx, client, pvclaimsList[i].Name, namespace)
16341634
gomega.Expect(err).NotTo(gomega.HaveOccurred())
1635-
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, pollTimeoutShort))
1635+
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, framework.PodDeleteTimeout))
16361636
err = e2eVSphere.waitForCNSVolumeToBeDeleted(pv.Spec.CSI.VolumeHandle)
16371637
gomega.Expect(err).NotTo(gomega.HaveOccurred())
16381638
}
@@ -1883,7 +1883,7 @@ var _ = ginkgo.Describe("[topology-multireplica] Topology-MultiReplica",
18831883
pv := getPvFromClaim(client, pvclaimsList[i].Namespace, pvclaimsList[i].Name)
18841884
err = fpv.DeletePersistentVolumeClaim(ctx, client, pvclaimsList[i].Name, namespace)
18851885
gomega.Expect(err).NotTo(gomega.HaveOccurred())
1886-
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, pollTimeoutShort))
1886+
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, framework.PodDeleteTimeout))
18871887
err = e2eVSphere.waitForCNSVolumeToBeDeleted(pv.Spec.CSI.VolumeHandle)
18881888
gomega.Expect(err).NotTo(gomega.HaveOccurred())
18891889
}
@@ -2265,7 +2265,7 @@ var _ = ginkgo.Describe("[topology-multireplica] Topology-MultiReplica",
22652265
pv := getPvFromClaim(client, pvclaimsList[i].Namespace, pvclaimsList[i].Name)
22662266
err = fpv.DeletePersistentVolumeClaim(ctx, client, pvclaimsList[i].Name, namespace)
22672267
gomega.Expect(err).NotTo(gomega.HaveOccurred())
2268-
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, pollTimeoutShort))
2268+
framework.ExpectNoError(fpv.WaitForPersistentVolumeDeleted(ctx, client, pv.Name, poll, framework.PodDeleteTimeout))
22692269
err = e2eVSphere.waitForCNSVolumeToBeDeleted(pv.Spec.CSI.VolumeHandle)
22702270
gomega.Expect(err).NotTo(gomega.HaveOccurred())
22712271
}

0 commit comments

Comments
 (0)