Added unit tests

Author: kolluria

pkg/syncer/cnsoperator/controller/cnsunregistervolume/controller.go

@@ -128,9 +128,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler) error {
 	err := ctrl.NewControllerManagedBy(mgr).Named("cnsunregistervolume-controller").
 		For(&v1a1.CnsUnregisterVolume{}).
 		WithEventFilter(predicate.GenerationChangedPredicate{}).
-		WithOptions(controller.Options{
-			MaxConcurrentReconciles: maxWorkerThreads},
-		).
+		WithOptions(controller.Options{MaxConcurrentReconciles: maxWorkerThreads}).
 		Complete(r)
 	if err != nil {
 		log.Errorf("Failed to build application controller. Err: %v", err)
@@ -164,8 +162,6 @@ var (
 	removeFinalizerFromPVC = k8s.RemoveFinalizerFromPVC
 )
 
-// TODO: find a way to optimise the logger usage in this file.
-
 // Reconcile reads that state of the cluster for a Reconciler object
 // and makes changes based on the state read and what is in the
 // Reconciler.Spec.
@@ -207,13 +203,15 @@ func (r *Reconciler) Reconcile(ctx context.Context,
 		err = r.reconcileDelete(ctx, *instance, request)
 		if err != nil {
 			log.Error("failed to reconcile with error ", err)
+			setInstanceError(ctx, r, instance, err.Error())
 			return reconcile.Result{RequeueAfter: backoff}, nil
 		}
 
 		log.Info("removing finalizer and allowing deletion of the instance")
 		err := removeFinalizer(ctx, r.client, instance)
 		if err != nil {
 			log.Error("failed to remove finalizer from the instance with error ", err)
+			setInstanceError(ctx, r, instance, "failed to remove finalizer from the instance")
 			return reconcile.Result{RequeueAfter: backoff}, nil
 		}
 
@@ -228,7 +226,7 @@ func (r *Reconciler) Reconcile(ctx context.Context,
 		return reconcile.Result{}, nil
 	}
 
-	err = r.reconcile(ctx, instance, request)
+	err = r.reconcile(ctx, *instance, request)
 	if err != nil {
 		log.Error("failed to reconcile with error ", err)
 		setInstanceError(ctx, r, instance, err.Error())
@@ -249,18 +247,18 @@ func (r *Reconciler) Reconcile(ctx context.Context,
 }
 
 func (r *Reconciler) reconcile(ctx context.Context,
-	instance *v1a1.CnsUnregisterVolume, request reconcile.Request) error {
+	instance v1a1.CnsUnregisterVolume, request reconcile.Request) error {
 	log := logger.GetLogger(ctx).With("name", request.NamespacedName)
 
-	params, err := getValidatedParams(ctx, *instance)
+	params, err := getValidatedParams(ctx, instance)
 	if err != nil {
 		log.Error("invalid input parameters", err)
 		return err
 	}
 
 	// Only protect the instance if input parameters are valid.
 	// This ensures faster deletion of instances with invalid parameters.
-	err = protectInstance(ctx, r.client, instance)
+	err = protectInstance(ctx, r.client, &instance)
 	if err != nil {
 		log.Error("failed to protect instance with error ", err)
 		return err
@@ -307,12 +305,11 @@ func (r *Reconciler) reconcileDelete(ctx context.Context,
 	if err != nil {
 		// If input parameters are invalid, the instance can be deleted
 		// since the volume cannot be unregistered.
-		log.Info("invalid input parameters")
+		log.Info("invalid input parameters ", instance.Spec)
 		return nil
 	}
 
-	usageInfo, err := getVolumeUsageInfo(ctx, params.pvcName, params.namespace,
-		instance.Spec.ForceUnregister)
+	usageInfo, err := getVolumeUsageInfo(ctx, params.pvcName, params.namespace, params.force)
 	if err != nil {
 		log.Error("failed to get volume usage info with error ", err)
 		return err
@@ -339,7 +336,9 @@ func (r *Reconciler) reconcileDelete(ctx context.Context,
 	return nil
 }
 
-func unregisterVolume(ctx context.Context, volMgr volumes.Manager,
+var unregisterVolume = _unregisterVolume
+
+func _unregisterVolume(ctx context.Context, volMgr volumes.Manager,
 	request reconcile.Request, params params) error {
 	log := logger.GetLogger(ctx).With("name", request.NamespacedName)