use global transaction support check (#3655)

Author: divyenpatel

pkg/csi/service/vanilla/controller.go

@@ -551,7 +551,6 @@ func (c *controller) createBlockVolumeWithPlacementEngineForMultiVC(ctx context.
 	// Check if requested volume size and source snapshot size matches.
 	volumeSource := req.GetVolumeContentSource()
 	var contentSourceSnapshotID, snapshotDatastoreURL string
-	var vCenterWithTransactionSupport bool
 	if volumeSource != nil {
 		sourceSnapshot := volumeSource.GetSnapshot()
 		if sourceSnapshot == nil {
@@ -582,13 +581,6 @@ func (c *controller) createBlockVolumeWithPlacementEngineForMultiVC(ctx context.
 				"VC %q does not support snapshot operations", vCenterHost)
 		}
 
-		vCenterWithTransactionSupport, err = c.managers.VcenterManager.IsCnsTransactionSupported(ctx, vCenterHost)
-		if err != nil {
-			return nil, csifault.CSIUnimplementedFault, logger.LogNewErrorCodef(log, codes.Internal,
-				"failed to check if cns transaction APIs are supported on VC %q due to error: %v",
-				vCenterHost, err)
-		}
-
 		// Query capacity in MB and datastore url for block volume snapshot.
 		volumeIds := []cnstypes.CnsVolumeId{{Id: cnsVolumeID}}
 		cnsVolumeDetailsMap, err := utils.QueryVolumeDetailsUtil(ctx, volumeManager, volumeIds)
@@ -650,8 +642,6 @@ func (c *controller) createBlockVolumeWithPlacementEngineForMultiVC(ctx context.
 		}
 		break
 	}
-
-	isTransactionAPIsSupported := vCenterWithTransactionSupport && isCSITransactionSupportEnabled
 	volumeOperationDetails, err := operationStore.GetRequestDetails(ctx, req.Name)
 	if err != nil {
 		if apierrors.IsNotFound(err) {
@@ -661,7 +651,7 @@ func (c *controller) createBlockVolumeWithPlacementEngineForMultiVC(ctx context.
 				"error occurred while getting CreateVolume task details for block volume %q. Error: %+v",
 				req.Name, err)
 		}
-	} else if !isTransactionAPIsSupported && volumeOperationDetails.OperationDetails != nil {
+	} else if !isCSITransactionSupportEnabled && volumeOperationDetails.OperationDetails != nil {
 		if volumeOperationDetails.OperationDetails.TaskStatus ==
 			cnsvolumeoperationrequest.TaskInvocationStatusSuccess &&
 			volumeOperationDetails.VolumeID != "" {
@@ -689,7 +679,7 @@ func (c *controller) createBlockVolumeWithPlacementEngineForMultiVC(ctx context.
 				},
 			}
 			volTaskAlreadyRegistered = true
-		} else if !isTransactionAPIsSupported && cnsvolume.IsTaskPending(volumeOperationDetails) {
+		} else if !isCSITransactionSupportEnabled && cnsvolume.IsTaskPending(volumeOperationDetails) {
 			// If task is already created in CNS for this volume but task is in progress,
 			// we need to monitor the task to check if volume creation is complete or not.
 			log.Infof("Volume with name %s has CreateVolume task %s pending on VC %q.",
@@ -883,7 +873,7 @@ func (c *controller) createBlockVolumeWithPlacementEngineForMultiVC(ctx context.
 						ClusterFlavor:        cnstypes.CnsClusterFlavorVanilla,
 					},
 					common.CreateBlockVolumeOptions{
-						IsCSITransactionSupportEnabled: isTransactionAPIsSupported,
+						IsCSITransactionSupportEnabled: isCSITransactionSupportEnabled,
 					})
 				if err != nil {
 					if cnsvolume.IsNotSupportedFaultType(ctx, faultType) {
@@ -968,7 +958,7 @@ func (c *controller) createBlockVolumeWithPlacementEngineForMultiVC(ctx context.
 					ClusterFlavor:        cnstypes.CnsClusterFlavorVanilla,
 				},
 				common.CreateBlockVolumeOptions{
-					IsCSITransactionSupportEnabled: isTransactionAPIsSupported,
+					IsCSITransactionSupportEnabled: isCSITransactionSupportEnabled,
 				})
 			if err != nil {
 				if cnsvolume.IsNotSupportedFaultType(ctx, faultType) {
@@ -2570,15 +2560,9 @@ func (c *controller) CreateSnapshot(ctx context.Context, req *csi.CreateSnapshot
 		// VolumeID and SnapshotID as the input, while corresponding snapshot APIs in upstream CSI require SnapshotID.
 		// So, we need to bridge the gap in vSphere CSI driver and return a combined SnapshotID to CSI Snapshotter.
 
-		vCenterWithTransactionSupport, err := vCenterManager.IsCnsTransactionSupported(ctx, vCenterHost)
-		if err != nil {
-			return nil, logger.LogNewErrorCodef(log, codes.Internal,
-				"failed to check if cns transaction APIs are supported on VC %q due to error: %v",
-				vCenterHost, err)
-		}
 		snapshotID, cnsSnapshotInfo, err := common.CreateSnapshotUtil(ctx, volumeManager,
 			volumeID, req.Name, &cnsvolume.CreateSnapshotExtraParams{
-				IsCSITransactionSupportEnabled: isCSITransactionSupportEnabled && vCenterWithTransactionSupport,
+				IsCSITransactionSupportEnabled: isCSITransactionSupportEnabled,
 			})
 		if err != nil {
 			return nil, logger.LogNewErrorCodef(log, codes.Internal,