Remove volume-extend fss (#3392)

Author: johnchobroadcom

manifests/guestcluster/1.33/pvcsi.yaml

@@ -660,7 +660,6 @@ metadata:
 ---
 apiVersion: v1
 data:
-  "volume-extend": "true"
   "volume-health": "true"
   "online-volume-extend": "true"
   "file-volume": "true"

manifests/supervisorcluster/1.32/cns-csi.yaml

@@ -549,7 +549,6 @@ spec:
 ---
 apiVersion: v1
 data:
-  "volume-extend": "true"
   "volume-health": "true"
   "online-volume-extend": "true"
   "file-volume": "true"

pkg/common/unittestcommon/utils.go

@@ -59,7 +59,6 @@ func GetFakeContainerOrchestratorInterface(orchestratorType int) (commonco.COCom
 		fakeCO := &FakeK8SOrchestrator{
 			featureStatesLock: &sync.RWMutex{},
 			featureStates: map[string]string{
-				"volume-extend":                     "true",
 				"volume-health":                     "true",
 				"csi-migration":                     "true",
 				"file-volume":                       "true",

pkg/csi/service/common/constants.go

@@ -379,8 +379,7 @@ const (
 	DefaultFeatureEnablementCheckInterval = 1 * time.Minute
 	// VolumeHealth is the feature flag name for volume health.
 	VolumeHealth = "volume-health"
-	// VolumeExtend is feature flag name for volume expansion.
-	VolumeExtend = "volume-extend"
+
 	// OnlineVolumeExtend guards the feature for online volume expansion.
 	OnlineVolumeExtend = "online-volume-extend"
 	// CSIMigration is feature flag for migrating in-tree vSphere volumes to CSI.

pkg/csi/service/wcp/controller.go

@@ -2648,10 +2648,6 @@ func (c *controller) ControllerExpandVolume(ctx context.Context, req *csi.Contro
 	controllerExpandVolumeInternal := func() (
 		*csi.ControllerExpandVolumeResponse, string, error) {
 		var err error
-		if !commonco.ContainerOrchestratorUtility.IsFSSEnabled(ctx, common.VolumeExtend) {
-			return nil, csifault.CSIUnimplementedFault, logger.LogNewErrorCode(log, codes.Unimplemented,
-				"expandVolume feature is disabled on the cluster")
-		}
 		log.Infof("ControllerExpandVolume: called with args %+v", *req)
 		// TODO: If the err is returned by invoking CNS API, then faultType should be
 		// populated by the underlying layer.

pkg/csi/service/wcpguest/controller.go

@@ -1376,11 +1376,6 @@ func (c *controller) ControllerExpandVolume(ctx context.Context, req *csi.Contro
 
 	controllerExpandVolumeInternal := func() (
 		*csi.ControllerExpandVolumeResponse, string, error) {
-		if !commonco.ContainerOrchestratorUtility.IsFSSEnabled(ctx, common.VolumeExtend) {
-			msg := "ExpandVolume feature is disabled on the cluster."
-			log.Warn(msg)
-			return nil, csifault.CSIUnimplementedFault, status.Error(codes.Unimplemented, msg)
-		}
 		log.Infof("ControllerExpandVolume: called with args %+v", *req)
 		// TODO: If the err is returned by invoking CNS API, then faultType should be
 		// populated by the underlying layer.

pkg/syncer/metadatasyncer.go

@@ -878,16 +878,12 @@ func InitMetadataSyncer(ctx context.Context, clusterFlavor cnstypes.CnsClusterFl
 		go func() {
 			for ; true; <-volumeResizeEnablementTicker.C {
 				ctx, log = logger.GetNewContextWithLogger()
-				if !metadataSyncer.coCommonInterface.IsFSSEnabled(ctx, common.VolumeExtend) {
-					log.Debugf("ExpandVolume feature is disabled on the cluster")
-				} else {
-					if err := initResizeReconciler(ctx, k8sClient, metadataSyncer.supervisorClient); err != nil {
-						log.Warnf("Error while initializing volume resize reconciler. Err:%+v. Retry will be triggered at %v",
-							err, time.Now().Add(common.DefaultFeatureEnablementCheckInterval))
-						continue
-					}
-					break
+				if err := initResizeReconciler(ctx, k8sClient, metadataSyncer.supervisorClient); err != nil {
+					log.Warnf("Error while initializing volume resize reconciler. Err:%+v. Retry will be triggered at %v",
+						err, time.Now().Add(common.DefaultFeatureEnablementCheckInterval))
+					continue
 				}
+				break
 			}
 		}()
 	}