Skip to content

Create k8sclient once in full sync #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −10
Open

Create k8sclient once in full sync #3688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions pkg/syncer/fullsync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,15 +187,20 @@ func CsiFullSync(ctx context.Context, metadataSyncer *metadataSyncInformer, vc s
return err
}

// Iterate through all the k8sPVs to find all PVs with node affinity missing and
// patch such PVs and their corresponding PVCs with topology discovered
if metadataSyncer.clusterFlavor == cnstypes.CnsClusterFlavorWorkload &&
IsWorkloadDomainIsolationSupported {
k8sClient, err := k8s.NewClient(ctx)
// Create k8sClient once for workload cluster operations to optimize performance
var k8sClient clientset.Interface
if metadataSyncer.clusterFlavor == cnstypes.CnsClusterFlavorWorkload {
k8sClient, err = k8sNewClient(ctx)
if err != nil {
log.Errorf("FullSync for VC %s: Failed to create kubernetes client. Err: %+v", vc, err)
return err
}
}

// Iterate through all the k8sPVs to find all PVs with node affinity missing and
// patch such PVs and their corresponding PVCs with topology discovered
if metadataSyncer.clusterFlavor == cnstypes.CnsClusterFlavorWorkload &&
IsWorkloadDomainIsolationSupported {
var pvWithMissingNodeAffinityList [](*v1.PersistentVolume)
for _, pv := range k8sPVs {
if pv.Spec.NodeAffinity == nil {
Expand Down Expand Up @@ -226,11 +231,7 @@ func CsiFullSync(ctx context.Context, metadataSyncer *metadataSyncInformer, vc s
// Iterate over all the file volume PVCs and check if file share export paths are added as annotations
// on it. If not added, then add file share export path annotations on such PVCs.
if metadataSyncer.clusterFlavor == cnstypes.CnsClusterFlavorWorkload {
k8sClient, err := k8sNewClient(ctx)
if err != nil {
log.Errorf("FullSync for VC %s: Failed to create kubernetes client. Err: %+v", vc, err)
return err
}
// Reuse the existing k8sClient instead of creating a new one
for _, pv := range k8sPVs {
if IsFileVolume(pv) {
if pvc, ok := pvToPVCMap[pv.Name]; ok {
Expand Down