removed lock from metrics tracking

Author: ttetyanka

cluster-autoscaler/core/scaledown/latencytracker/node_latency_tracker.go

@@ -1,7 +1,6 @@
 package latencytracker
 
 import (
-	"sync"
 	"time"
 
 	"k8s.io/autoscaler/cluster-autoscaler/metrics"
@@ -16,7 +15,6 @@ type NodeInfo struct {
 }
 
 type NodeLatencyTracker struct {
-	sync.Mutex
 	nodes map[string]NodeInfo
 }
 
@@ -28,9 +26,6 @@ func NewNodeLatencyTracker() *NodeLatencyTracker {
 }
 
 func (t *NodeLatencyTracker) UpdateStateWithUnneededList(list []NodeInfo, timestamp time.Time) {
-	t.Lock()
-	defer t.Unlock()
-
 	currentSet := make(map[string]struct{}, len(list))
 	for _, info := range list {
 		currentSet[info.Name] = struct{}{}
@@ -49,9 +44,6 @@ func (t *NodeLatencyTracker) UpdateStateWithUnneededList(list []NodeInfo, timest
 
 // ObserveDeletion is called by the actuator just before node deletion.
 func (t *NodeLatencyTracker) ObserveDeletion(nodeName string, timestamp time.Time) {
-	t.Lock()
-	defer t.Unlock()
-
 	if info, exists := t.nodes[nodeName]; exists {
 		duration := timestamp.Sub(info.UnneededSince)
 

cluster-autoscaler/core/scaledown/latencytracker/node_latency_tracker_test.go

@@ -29,8 +29,6 @@ func TestUpdateStateWithUnneededList_AddsNewNodes(t *testing.T) {
 
 	tracker.UpdateStateWithUnneededList([]NodeInfo{node}, now)
 
-	tracker.Lock()
-	defer tracker.Unlock()
 	if _, ok := tracker.nodes["node1"]; !ok {
 		t.Errorf("expected node1 to be tracked, but was not")
 	}
@@ -44,8 +42,6 @@ func TestUpdateStateWithUnneededList_DoesNotDuplicate(t *testing.T) {
 	tracker.UpdateStateWithUnneededList([]NodeInfo{node}, now)
 	tracker.UpdateStateWithUnneededList([]NodeInfo{node}, now.Add(time.Minute))
 
-	tracker.Lock()
-	defer tracker.Unlock()
 	if len(tracker.nodes) != 1 {
 		t.Errorf("expected 1 tracked node, got %d", len(tracker.nodes))
 	}
@@ -63,8 +59,6 @@ func TestObserveDeletion_RemovesNode(t *testing.T) {
 
 	tracker.ObserveDeletion("node1", now)
 
-	tracker.Lock()
-	defer tracker.Unlock()
 	if _, ok := tracker.nodes["node1"]; ok {
 		t.Errorf("expected node1 removed after ObserveDeletion")
 	}
@@ -76,8 +70,6 @@ func TestObserveDeletion_NoOpIfNodeNotTracked(t *testing.T) {
 
 	tracker.ObserveDeletion("node1", now)
 
-	tracker.Lock()
-	defer tracker.Unlock()
 	if len(tracker.nodes) != 0 {
 		t.Errorf("expected no nodes tracked, got %d", len(tracker.nodes))
 	}
@@ -126,8 +118,6 @@ func TestConcurrentUpdatesAndDeletions(t *testing.T) {
 	close(stop)
 	wg.Wait()
 
-	tracker.Lock()
-	defer tracker.Unlock()
 	if len(tracker.nodes) > 1 {
 		t.Errorf("expected at most 1 tracked node, got %d", len(tracker.nodes))
 	}