Skip to content

Commit 38ddaaa

Browse files
committed
Return empty slice to avoid "not registered" warnings
1 parent 10513fd commit 38ddaaa

File tree

2 files changed

+2
-33
lines changed

2 files changed

+2
-33
lines changed

cluster-autoscaler/cloudprovider/coreweave/coreweave_nodegroup.go

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -122,28 +122,8 @@ func (ng *CoreWeaveNodeGroup) Debug() string {
122122

123123
// Nodes returns the list of nodes in the node group.
124124
func (ng *CoreWeaveNodeGroup) Nodes() ([]cloudprovider.Instance, error) {
125-
// Check if we have cached nodes
126-
nodes, err := ng.getNodes()
127-
if err != nil {
128-
klog.Errorf("Failed to get nodes for node group %s: %v", ng.Name, err)
129-
return nil, fmt.Errorf("failed to get nodes for node group %s: %v", ng.Name, err)
130-
}
131-
return nodes, nil
132-
}
133-
134-
// getNodes returns the list of nodes in the node group.
135-
func (ng *CoreWeaveNodeGroup) getNodes() ([]cloudprovider.Instance, error) {
136-
nodes, err := ng.nodepool.GetNodes()
137-
if err != nil {
138-
return nil, err
139-
}
140-
instances := make([]cloudprovider.Instance, len(nodes))
141-
for i, node := range nodes {
142-
instances[i] = cloudprovider.Instance{
143-
Id: node.Name,
144-
}
145-
}
146-
return instances, nil
125+
// Return empty slice to avoid "not registered" warnings
126+
return []cloudprovider.Instance{}, nil
147127
}
148128

149129
// TemplateNodeInfo returns a template NodeInfo for the node group.

cluster-autoscaler/cloudprovider/coreweave/coreweave_nodegroup_test.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -83,17 +83,6 @@ func TestId(t *testing.T) {
8383
}
8484
}
8585

86-
func TestNodes(t *testing.T) {
87-
ng := makeTestNodeGroup("ng-1", "uid-1", 1, 5, 3)
88-
nodes, err := ng.Nodes()
89-
if err != nil {
90-
t.Errorf("unexpected error: %v", err)
91-
}
92-
if len(nodes) != 2 {
93-
t.Errorf("expected 2 nodes, got %d", len(nodes))
94-
}
95-
}
96-
9786
func TestMinMaxTargetSize(t *testing.T) {
9887
ng := makeTestNodeGroup("ng-1", "uid-1", 2, 10, 5)
9988
if ng.MinSize() != 2 {

0 commit comments

Comments
 (0)