Skip to content

Commit 3956443

Browse files
committed
fix: updated resourceapi to v1
Signed-off-by: MenD32 <[email protected]>
1 parent 9f2c8db commit 3956443

File tree

2 files changed

+27
-34
lines changed

2 files changed

+27
-34
lines changed

cluster-autoscaler/simulator/dynamicresources/utils/utilization.go

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020
"fmt"
2121

2222
v1 "k8s.io/api/core/v1"
23-
resourceapi "k8s.io/api/resource/v1beta1"
23+
resourceapi "k8s.io/api/resource/v1"
2424
"k8s.io/apimachinery/pkg/api/resource"
2525
"k8s.io/autoscaler/cluster-autoscaler/simulator/framework"
2626
)
@@ -89,13 +89,13 @@ func calculatePoolUtil(unallocated, allocated []resourceapi.Device, resourceSlic
8989
devicesWithoutCounters := 0
9090

9191
for _, device := range allocated {
92-
if device.Basic == nil || device.Basic.ConsumesCounters == nil {
92+
if device.ConsumesCounters == nil {
9393
devicesWithoutCounters++
9494
allocatedDevicesWithoutCounters++
9595
}
9696
}
9797
for _, device := range unallocated {
98-
if device.Basic == nil || device.Basic.ConsumesCounters == nil {
98+
if device.ConsumesCounters == nil {
9999
devicesWithoutCounters++
100100
}
101101
}
@@ -126,13 +126,10 @@ func calculatePoolUtil(unallocated, allocated []resourceapi.Device, resourceSlic
126126
func calculateConsumedCounters(devices []resourceapi.Device) map[string]map[string]resource.Quantity {
127127
countersConsumed := map[string]map[string]resource.Quantity{}
128128
for _, device := range devices {
129-
if device.Basic == nil {
129+
if device.ConsumesCounters == nil {
130130
continue
131131
}
132-
if device.Basic.ConsumesCounters == nil {
133-
continue
134-
}
135-
for _, consumedCounter := range device.Basic.ConsumesCounters {
132+
for _, consumedCounter := range device.ConsumesCounters {
136133
if _, ok := countersConsumed[consumedCounter.CounterSet]; !ok {
137134
countersConsumed[consumedCounter.CounterSet] = map[string]resource.Quantity{}
138135
}

cluster-autoscaler/simulator/dynamicresources/utils/utilization_test.go

Lines changed: 22 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424
"github.com/google/go-cmp/cmp/cmpopts"
2525

2626
apiv1 "k8s.io/api/core/v1"
27-
resourceapi "k8s.io/api/resource/v1beta1"
27+
resourceapi "k8s.io/api/resource/v1"
2828
"k8s.io/apimachinery/pkg/api/resource"
2929
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3030
"k8s.io/apimachinery/pkg/types"
@@ -220,19 +220,17 @@ func testResourceSlicesWithPartionableDevices(driverName, poolName, nodeName str
220220
devices,
221221
resourceapi.Device{
222222
Name: fmt.Sprintf("gpu-0-partition-%d", i),
223-
Basic: &resourceapi.BasicDevice{
224-
Capacity: map[resourceapi.QualifiedName]resourceapi.DeviceCapacity{
225-
"memory": {
226-
Value: resource.MustParse("10Gi"),
227-
},
223+
Capacity: map[resourceapi.QualifiedName]resourceapi.DeviceCapacity{
224+
"memory": {
225+
Value: resource.MustParse("10Gi"),
228226
},
229-
ConsumesCounters: []resourceapi.DeviceCounterConsumption{
230-
{
231-
CounterSet: "gpu-0-counter-set",
232-
Counters: map[string]resourceapi.Counter{
233-
"memory": {
234-
Value: resource.MustParse("10Gi"),
235-
},
227+
},
228+
ConsumesCounters: []resourceapi.DeviceCounterConsumption{
229+
{
230+
CounterSet: "gpu-0-counter-set",
231+
Counters: map[string]resourceapi.Counter{
232+
"memory": {
233+
Value: resource.MustParse("10Gi"),
236234
},
237235
},
238236
},
@@ -243,19 +241,17 @@ func testResourceSlicesWithPartionableDevices(driverName, poolName, nodeName str
243241
devices = append(devices,
244242
resourceapi.Device{
245243
Name: "gpu-0",
246-
Basic: &resourceapi.BasicDevice{
247-
Capacity: map[resourceapi.QualifiedName]resourceapi.DeviceCapacity{
248-
"memory": {
249-
Value: resource.MustParse(fmt.Sprintf("%dGi", 10*partitionCount)),
250-
},
244+
Capacity: map[resourceapi.QualifiedName]resourceapi.DeviceCapacity{
245+
"memory": {
246+
Value: resource.MustParse(fmt.Sprintf("%dGi", 10*partitionCount)),
251247
},
252-
ConsumesCounters: []resourceapi.DeviceCounterConsumption{
253-
{
254-
CounterSet: "gpu-0-counter-set",
255-
Counters: map[string]resourceapi.Counter{
256-
"memory": {
257-
Value: resource.MustParse(fmt.Sprintf("%dGi", 10*partitionCount)),
258-
},
248+
},
249+
ConsumesCounters: []resourceapi.DeviceCounterConsumption{
250+
{
251+
CounterSet: "gpu-0-counter-set",
252+
Counters: map[string]resourceapi.Counter{
253+
"memory": {
254+
Value: resource.MustParse(fmt.Sprintf("%dGi", 10*partitionCount)),
259255
},
260256
},
261257
},
@@ -266,7 +262,7 @@ func testResourceSlicesWithPartionableDevices(driverName, poolName, nodeName str
266262
ObjectMeta: metav1.ObjectMeta{Name: sliceName, UID: types.UID(sliceName)},
267263
Spec: resourceapi.ResourceSliceSpec{
268264
Driver: driverName,
269-
NodeName: nodeName,
265+
NodeName: &nodeName,
270266
Pool: resourceapi.ResourcePool{Name: poolName, Generation: int64(poolGen), ResourceSliceCount: 1},
271267
Devices: devices,
272268
SharedCounters: []resourceapi.CounterSet{

0 commit comments

Comments
 (0)