Skip to content

Commit 55f24a2

Browse files
committed
remove GetUnneededTimeForNode
1 parent 519e89c commit 55f24a2

File tree

1 file changed

+0
-36
lines changed
  • cluster-autoscaler/core/scaledown/unneeded

1 file changed

+0
-36
lines changed

cluster-autoscaler/core/scaledown/unneeded/nodes.go

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ func NewNodes(sdtg scaleDownTimeGetter, limitsFinder *resource.LimitsFinder, nlt
6565
return &Nodes{
6666
sdtg: sdtg,
6767
limitsFinder: limitsFinder,
68-
unneededTimeCache: make(map[string]time.Duration),
6968
nodeLatencyTracker: nlt,
7069
}
7170
}
@@ -214,41 +213,6 @@ func (n *Nodes) RemovableAt(context *context.AutoscalingContext, scaleDownContex
214213
return
215214
}
216215

217-
// GetUnneededTimeForNode returns the unneeded timeout for a given node if tracked.
218-
// Returns (duration, true) if found, otherwise (0, false).
219-
func (n *Nodes) GetUnneededTimeForNode(ctx *context.AutoscalingContext, nodeName string) (time.Duration, bool) {
220-
v, found := n.byName[nodeName]
221-
if !found {
222-
klog.V(4).Infof("Skipping - node %s not found in unneded list", nodeName)
223-
return 0, false
224-
}
225-
226-
node := v.ntbr.Node
227-
nodeGroup, err := ctx.CloudProvider.NodeGroupForNode(node)
228-
if err != nil {
229-
klog.Errorf("Error while getting node group for %s: %v", nodeName, err)
230-
return 0, false
231-
}
232-
if nodeGroup == nil || reflect.ValueOf(nodeGroup).IsNil() {
233-
klog.V(4).Infof("Skipping %s - no node group", nodeName)
234-
return 0, false
235-
}
236-
237-
ngID := nodeGroup.Id()
238-
if cached, ok := n.unneededTimeCache[ngID]; ok {
239-
return cached, true
240-
}
241-
242-
unneededTime, err := n.sdtg.GetScaleDownUnneededTime(nodeGroup)
243-
if err != nil {
244-
klog.Errorf("Error getting ScaleDownUnneededTime for node %s: %v", nodeName, err)
245-
return 0, false
246-
}
247-
248-
n.unneededTimeCache[ngID] = unneededTime
249-
return unneededTime, true
250-
}
251-
252216
func (n *Nodes) unremovableReason(context *context.AutoscalingContext, scaleDownContext nodes.ScaleDownContext, v *node, ts time.Time, nodeGroupSize map[string]int) simulator.UnremovableReason {
253217
node := v.ntbr.Node
254218
// Check if node is marked with no scale down annotation.

0 commit comments

Comments
 (0)