Skip to content

Commit 612d6ee

Browse files
authored
Merge pull request #8667 from adrianmoisey/move-golangci-lint
Move golangci-lint for VPA to its own job
2 parents 804e189 + 6371fa2 commit 612d6ee

File tree

3 files changed

+38
-7
lines changed

3 files changed

+38
-7
lines changed

.github/workflows/ci.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,6 @@ jobs:
4343
env:
4444
GO111MODULE: auto
4545

46-
- name: golangci-lint - vertical-pod-autoscaler
47-
uses: golangci/golangci-lint-action@v8
48-
with:
49-
args: --timeout=30m
50-
working-directory: ${{ env.GOPATH }}/src/k8s.io/autoscaler/vertical-pod-autoscaler
51-
5246
- name: Test
5347
working-directory: ${{ env.GOPATH }}/src/k8s.io/autoscaler
5448
run: hack/for-go-proj.sh test
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
name: Lint
2+
3+
on:
4+
push:
5+
paths:
6+
- 'vertical-pod-autoscaler/**'
7+
pull_request:
8+
paths:
9+
- 'vertical-pod-autoscaler/**'
10+
11+
env:
12+
GOPATH: ${{ github.workspace }}/go
13+
14+
permissions:
15+
contents: read
16+
17+
jobs:
18+
golangci:
19+
name: golangci-lint - VPA
20+
runs-on: ubuntu-latest
21+
steps:
22+
- uses: actions/checkout@v5
23+
with:
24+
path: ${{ env.GOPATH }}/src/k8s.io/autoscaler
25+
- uses: actions/setup-go@v6
26+
with:
27+
go-version: '1.25.0'
28+
cache-dependency-path: |
29+
${{ env.GOPATH}}/src/k8s.io/autoscaler/vertical-pod-autoscaler/go.sum
30+
${{ env.GOPATH}}/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/go.sum
31+
32+
- name: golangci-lint - vertical-pod-autoscaler
33+
uses: golangci/golangci-lint-action@v8
34+
with:
35+
args: --timeout=30m
36+
working-directory: ${{ env.GOPATH }}/src/k8s.io/autoscaler/vertical-pod-autoscaler

vertical-pod-autoscaler/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ Also refer to the [FAQ](./docs/faq.md) for more.
3939

4040
## Components and Architecture
4141

42-
The Vertical Pod Autoscaler consists of three parts. The recommender, updater and admission-controller. Read more about them on the [components](./docs/components.md) page.
42+
The Vertical Pod Autoscaler consists of three parts. The recommender, updater and admission-controller.
43+
Read more about them on the [components](./docs/components.md) page.
4344

4445
## Features and Known limitations
4546

0 commit comments

Comments
 (0)