Skip to content

Commit 7824eae

Browse files
committed
cover planner node deletion latency tracking with test
1 parent cfae8da commit 7824eae

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

cluster-autoscaler/core/scaledown/latencytracker/node_latency_tracker.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,12 @@ func (t *NodeLatencyTracker) ObserveDeletion(nodeName string, timestamp time.Tim
7474
delete(t.nodes, nodeName)
7575
}
7676
}
77+
78+
// GetTrackedNodes returns the names of all nodes currently tracked as unneeded.
79+
func (t *NodeLatencyTracker) GetTrackedNodes() []string {
80+
names := make([]string, 0, len(t.nodes))
81+
for name := range t.nodes {
82+
names = append(names, name)
83+
}
84+
return names
85+
}

cluster-autoscaler/core/scaledown/planner/planner_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,13 @@ func TestUpdateClusterState(t *testing.T) {
522522
assert.Equal(t, wantUnneeded[n.Name], p.unneededNodes.Contains(n.Name), []string{n.Name, "unneeded"})
523523
assert.Equal(t, wantUnremovable[n.Name], p.unremovableNodes.Contains(n.Name), []string{n.Name, "unremovable"})
524524
}
525+
tracked := p.nodeLatencyTracker.GetTrackedNodes()
526+
for _, name := range tc.wantUnneeded {
527+
assert.Contains(t, tracked, name, "expected node in latency tracker")
528+
}
529+
for _, name := range tc.wantUnremovable {
530+
assert.NotContains(t, tracked, name, "expected node not in latency tracker")
531+
}
525532
})
526533
}
527534
}

0 commit comments

Comments
 (0)