Skip to content

Commit 9811884

Browse files
committed
remove GetUnneededTimeForNode
1 parent 41b9b45 commit 9811884

File tree

1 file changed

+0
-36
lines changed
  • cluster-autoscaler/core/scaledown/unneeded

1 file changed

+0
-36
lines changed

cluster-autoscaler/core/scaledown/unneeded/nodes.go

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ func NewNodes(sdtg scaleDownTimeGetter, limitsFinder *resource.LimitsFinder, nlt
6363
return &Nodes{
6464
sdtg: sdtg,
6565
limitsFinder: limitsFinder,
66-
unneededTimeCache: make(map[string]time.Duration),
6766
nodeLatencyTracker: nlt,
6867
}
6968
}
@@ -146,41 +145,6 @@ func (n *Nodes) RemovableAt(context *context.AutoscalingContext, scaleDownContex
146145
return
147146
}
148147

149-
// GetUnneededTimeForNode returns the unneeded timeout for a given node if tracked.
150-
// Returns (duration, true) if found, otherwise (0, false).
151-
func (n *Nodes) GetUnneededTimeForNode(ctx *context.AutoscalingContext, nodeName string) (time.Duration, bool) {
152-
v, found := n.byName[nodeName]
153-
if !found {
154-
klog.V(4).Infof("Skipping - node %s not found in unneded list", nodeName)
155-
return 0, false
156-
}
157-
158-
node := v.ntbr.Node
159-
nodeGroup, err := ctx.CloudProvider.NodeGroupForNode(node)
160-
if err != nil {
161-
klog.Errorf("Error while getting node group for %s: %v", nodeName, err)
162-
return 0, false
163-
}
164-
if nodeGroup == nil || reflect.ValueOf(nodeGroup).IsNil() {
165-
klog.V(4).Infof("Skipping %s - no node group", nodeName)
166-
return 0, false
167-
}
168-
169-
ngID := nodeGroup.Id()
170-
if cached, ok := n.unneededTimeCache[ngID]; ok {
171-
return cached, true
172-
}
173-
174-
unneededTime, err := n.sdtg.GetScaleDownUnneededTime(nodeGroup)
175-
if err != nil {
176-
klog.Errorf("Error getting ScaleDownUnneededTime for node %s: %v", nodeName, err)
177-
return 0, false
178-
}
179-
180-
n.unneededTimeCache[ngID] = unneededTime
181-
return unneededTime, true
182-
}
183-
184148
func (n *Nodes) unremovableReason(context *context.AutoscalingContext, scaleDownContext nodes.ScaleDownContext, v *node, ts time.Time, nodeGroupSize map[string]int) simulator.UnremovableReason {
185149
node := v.ntbr.Node
186150
// Check if node is marked with no scale down annotation.

0 commit comments

Comments
 (0)