change name flag from nodeLatencyTrackingEnabled to nodeRemovalLatencyTrackingEnabled

Author: ttetyanka

cluster-autoscaler/config/autoscaling_options.go

@@ -345,12 +345,8 @@ type AutoscalingOptions struct {
 	// NodeDeletionCandidateTTL is the maximum time a node can be marked as removable without being deleted.
 	// This is used to prevent nodes from being stuck in the removable state during if the CA deployment becomes inactive.
 	NodeDeletionCandidateTTL time.Duration
-	//CapacitybufferControllerEnabled tells if CA should run default capacity buffer as sub-process or not
-	CapacitybufferControllerEnabled bool
-	// CapacitybufferPodInjectionEnabled tells if CA should injects fake pods for capacity buffers that are ready for provisioning
-	CapacitybufferPodInjectionEnabled bool
-	// NodeLatencyTrackingEnabled is used to enable/disable node latency tracking.
-	NodeLatencyTrackingEnabled bool
+	// NodeRemovalLatencyTrackingEnabled is used to enable/disable node removal latency tracking.
+	NodeRemovalLatencyTrackingEnabled bool
 }
 
 // KubeClientOptions specify options for kube client

cluster-autoscaler/config/flags/flags.go

@@ -228,9 +228,7 @@ var (
 	clusterSnapshotParallelism                   = flag.Int("cluster-snapshot-parallelism", 16, "Maximum parallelism of cluster snapshot creation.")
 	checkCapacityProcessorInstance               = flag.String("check-capacity-processor-instance", "", "Name of the processor instance. Only ProvisioningRequests that define this name in their parameters with the key \"processorInstance\" will be processed by this CA instance. It only refers to check capacity ProvisioningRequests, but if not empty, best-effort atomic ProvisioningRequests processing is disabled in this instance. Not recommended: Until CA 1.35, ProvisioningRequests with this name as prefix in their class will be also processed.")
 	nodeDeletionCandidateTTL                     = flag.Duration("node-deletion-candidate-ttl", time.Duration(0), "Maximum time a node can be marked as removable before the marking becomes stale. This sets the TTL of Cluster-Autoscaler's state if the Cluste-Autoscaler deployment becomes inactive")
-	capacitybufferControllerEnabled              = flag.Bool("capacity-buffer-controller-enabled", false, "Whether to enable the default controller for capacity buffers or not")
-	capacitybufferPodInjectionEnabled            = flag.Bool("capacity-buffer-pod-injection-enabled", false, "Whether to enable pod list processor that processes ready capacity buffers and injects fake pods accordingly")
-	nodeLatencyTrackingEnabled                   = flag.Bool("enable-node-latency-tracking", false, "Whether logic for monitoring of node latency is enabled.")
+	nodeRemovalLatencyTrackingEnabled            = flag.Bool("enable-node-removal-latency-tracking", false, "Whether to track latency from when a node is marked unneeded until it is removed or needed again.")
 
 	// Deprecated flags
 	ignoreTaintsFlag = multiStringFlag("ignore-taint", "Specifies a taint to ignore in node templates when considering to scale a node group (Deprecated, use startup-taints instead)")
@@ -413,9 +411,7 @@ func createAutoscalingOptions() config.AutoscalingOptions {
 		ProactiveScaleupEnabled:                      *proactiveScaleupEnabled,
 		PodInjectionLimit:                            *podInjectionLimit,
 		NodeDeletionCandidateTTL:                     *nodeDeletionCandidateTTL,
-		CapacitybufferControllerEnabled:              *capacitybufferControllerEnabled,
-		CapacitybufferPodInjectionEnabled:            *capacitybufferPodInjectionEnabled,
-		NodeLatencyTrackingEnabled:                   *nodeLatencyTrackingEnabled,
+		NodeRemovalLatencyTrackingEnabled:            *nodeRemovalLatencyTrackingEnabled,
 	}
 }
 

cluster-autoscaler/core/static_autoscaler.go

@@ -177,7 +177,7 @@ func NewStaticAutoscaler(
 	// TODO: Populate the ScaleDownActuator/Planner fields in AutoscalingContext
 	// during the struct creation rather than here.
 	var nldt *latencytracker.NodeLatencyTracker
-	if autoscalingContext.AutoscalingOptions.NodeLatencyTrackingEnabled {
+	if autoscalingContext.AutoscalingOptions.NodeRemovalLatencyTrackingEnabled {
 		nldt = latencytracker.NewNodeLatencyTracker()
 	}
 	scaleDownPlanner := planner.New(autoscalingContext, processors, deleteOptions, drainabilityRules, nldt)