removed test for same name check, not a valid case

Author: jklaw90

vertical-pod-autoscaler/pkg/utils/resources/resourcehelpers.go

@@ -74,10 +74,10 @@ func containerStatusFor(containerName string, containerStatuses []v1.ContainerSt
 }
 
 func isInitContainer(containerName string, pod *v1.Pod) bool {
-	for _, container := range pod.Spec.Containers {
+	for _, container := range pod.Spec.InitContainers {
 		if container.Name == containerName {
-			return false
+			return true
 		}
 	}
-	return true
+	return false
 }

vertical-pod-autoscaler/pkg/utils/resources/resourcehelpers_test.go

@@ -106,31 +106,6 @@ func TestContainerRequestsAndLimits(t *testing.T) {
 			wantRequests: nil,
 			wantLimits:   nil,
 		},
-		{
-			desc:          "Init container with the same name as the container is ignored",
-			containerName: "container-1",
-			pod: test.Pod().AddInitContainer(
-				test.Container().WithName("container-1").
-					WithCPURequest(resource.MustParse("1")).
-					WithMemRequest(resource.MustParse("10Mi")).
-					WithCPULimit(resource.MustParse("2")).
-					WithMemLimit(resource.MustParse("20Mi")).Get()).
-				AddContainer(
-					test.Container().WithName("container-1").
-						WithCPURequest(resource.MustParse("4")).
-						WithMemRequest(resource.MustParse("40Mi")).
-						WithCPULimit(resource.MustParse("5")).
-						WithMemLimit(resource.MustParse("50Mi")).Get()).
-				Get(),
-			wantRequests: apiv1.ResourceList{
-				apiv1.ResourceCPU:    resource.MustParse("4"),
-				apiv1.ResourceMemory: resource.MustParse("40Mi"),
-			},
-			wantLimits: apiv1.ResourceList{
-				apiv1.ResourceCPU:    resource.MustParse("5"),
-				apiv1.ResourceMemory: resource.MustParse("50Mi"),
-			},
-		},
 		{
 			desc:          "InitContainer selected",
 			containerName: "container",