Skip to content

Commit a4d2d6c

Browse files
author
Ray Wainman
committed
added clarification on eviction after in-place failure
1 parent 047e6ad commit a4d2d6c

File tree

1 file changed

+5
-2
lines changed
  • vertical-pod-autoscaler/enhancements/4016-in-place-updates-support

1 file changed

+5
-2
lines changed

vertical-pod-autoscaler/enhancements/4016-in-place-updates-support/README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,13 @@ be able to perform an eviction, including:
153153
* If `CanEvict` is false.
154154
* If any of the `EvictionRequirements` on the VPA are not true.
155155

156-
These additional resizes can be attempted because the eviction fallback would fail anyway.
156+
If the in-place resize operation fails in this case, VPA can still proceed with the normal eviction
157+
path which would get blocked anyway due to these conditions preventing it from happening.
157158

158159
The VPA updater will evict a pod to actuate a recommendation if it attempted to apply the
159-
recommendation in place and failed.
160+
recommendation in place and failed. This will happen even if we attempted the in-place resize
161+
for conditions that normally would not lead to an eviction. This is safe because the eviction would
162+
be prevented anyway.
160163

161164
VPA updater will consider that the update failed if:
162165
* The pod has condition `PodResizePending` with reason `Infeasible` or

0 commit comments

Comments
 (0)