Skip to content

Commit aa1d413

Browse files
authored
Merge pull request #7970 from laoj2/fix-pod-condition
Replace PodResizing with PodResizeInProgress pod condition in AEP-4016
2 parents 52cd68a + 8892f21 commit aa1d413

File tree

1 file changed

+4
-3
lines changed
  • vertical-pod-autoscaler/enhancements/4016-in-place-updates-support

1 file changed

+4
-3
lines changed

vertical-pod-autoscaler/enhancements/4016-in-place-updates-support/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,8 @@ VPA updater will consider that the update failed if:
170170
* The pod has condition `PodResizePending` with reason `Infeasible` or
171171
* The pod has condition `PodResizePending` with reason `Deferred` and more than 5 minutes elapsed
172172
since the update or
173-
* The pod has condition `PodResizing` and more than 1 hour elapsed since the update or
173+
* The pod has condition `PodResizeInProgress` and more than 1 hour elapsed since
174+
the update or
174175
* Patch attempt returns an error.
175176

176177
Note that in the initial version of In-Place updates, memory limit downscaling will always fail
@@ -228,7 +229,7 @@ Today, VPA updater considers the following conditions when deciding if it should
228229
* Outside recommended range,
229230
* Long-lived pod with significant change.
230231
* `EvictionRequirements` are all true.
231-
232+
232233
`InPlaceOrRecreate` will attempt to apply an update in place if it meets at least one
233234
of the following conditions:
234235
* Quick OOM,
@@ -251,7 +252,7 @@ of the following conditions:
251252
The following test scenarios will be added to e2e tests. The `InPlaceOrRecreate` mode will be
252253
tested in the following scenarios:
253254

254-
* Admission controller applies recommendation to pod controlled by VPA.
255+
* Admission controller applies recommendation to pod controlled by VPA.
255256
* In-place update applied to all containers of a pod.
256257
* In-place update will fail. Pod should be evicted and the recommendation applied.
257258
* In-place update will fail but `CanEvict` is false, pod should not be evicted.

0 commit comments

Comments
 (0)