Skip to content

Commit ac977ed

Browse files
committed
use k8s sets
Signed-off-by: Omer Aplatony <[email protected]>
1 parent b11d1ec commit ac977ed

File tree

1 file changed

+4
-4
lines changed
  • vertical-pod-autoscaler/pkg/updater/logic

1 file changed

+4
-4
lines changed

vertical-pod-autoscaler/pkg/updater/logic/updater.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
apiv1 "k8s.io/api/core/v1"
2727
"k8s.io/apimachinery/pkg/fields"
2828
"k8s.io/apimachinery/pkg/labels"
29+
"k8s.io/apimachinery/pkg/util/sets"
2930
kube_client "k8s.io/client-go/kubernetes"
3031
"k8s.io/client-go/kubernetes/fake"
3132
corescheme "k8s.io/client-go/kubernetes/scheme"
@@ -167,7 +168,7 @@ func (u *updater) RunOnce(ctx context.Context) {
167168
inPlaceFeatureEnable := features.Enabled(features.InPlaceOrRecreate)
168169

169170
var podsList []*apiv1.Pod
170-
seenPods := make(map[string]struct{})
171+
seenPods := sets.New[string]()
171172

172173
for _, vpa := range vpaList {
173174
if slices.Contains(u.ignoredNamespaces, vpa.Namespace) {
@@ -196,9 +197,8 @@ func (u *updater) RunOnce(ctx context.Context) {
196197

197198
// handle the case of overlapping VPA selectors
198199
for _, pod := range podsWithSelector {
199-
uid := string(pod.UID)
200-
if _, seen := seenPods[uid]; !seen {
201-
seenPods[uid] = struct{}{}
200+
if !seenPods.Has(pod.Name) {
201+
seenPods.Insert(pod.Name)
202202
podsList = append(podsList, pod)
203203
}
204204
}

0 commit comments

Comments
 (0)