Address review feedback from plkokanov

Author: ialidzhikov

vertical-pod-autoscaler/pkg/utils/vpa/capping.go

@@ -200,7 +200,9 @@ func applyVPAPolicyForContainer(containerName string,
 
 	var maxAllowed apiv1.ResourceList
 	if containerPolicy != nil {
-		maxAllowed = containerPolicy.MaxAllowed
+		// Deep copy containerPolicy.MaxAllowed as maxAllowed can later on be merged with globalMaxAllowed.
+		// Deep copy is needed to prevent unwanted modifications to containerPolicy.MaxAllowed.
+		maxAllowed = containerPolicy.MaxAllowed.DeepCopy()
 	}
 	if maxAllowed == nil {
 		maxAllowed = globalMaxAllowed

vertical-pod-autoscaler/pkg/utils/vpa/capping_test.go

@@ -569,9 +569,14 @@ func TestApplyVPAPolicy(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.Name, func(t *testing.T) {
+			resourcePolicyCopy := tt.ResourcePolicy.DeepCopy()
+
 			actual, err := ApplyVPAPolicy(tt.PodRecommendation, tt.ResourcePolicy, tt.GlobalMaxAllowed)
 			assert.Nil(t, err)
 			assert.Equal(t, tt.Expected, actual)
+
+			// Make sure that the func does not have a side affect and does not modify the passed resource policy.
+			assert.Equal(t, resourcePolicyCopy, tt.ResourcePolicy)
 		})
 	}
 }