Skip to content

Commit bcd273f

Browse files
committed
We no longer return detailed taint information
kubernetes/kubernetes#134740
1 parent acb3dda commit bcd273f

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

cluster-autoscaler/simulator/clustersnapshot/predicate/plugin_runner_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,13 @@ func TestDebugInfo(t *testing.T) {
319319

320320
_, _, predicateErr := defaultPluginRunner.RunFiltersOnNode(p1, "n1")
321321
assert.NotNil(t, predicateErr)
322-
assert.Contains(t, predicateErr.FailingPredicateReasons(), "node(s) had untolerated taint {SomeTaint: WhyNot?}")
323-
assert.Contains(t, predicateErr.Error(), "node(s) had untolerated taint {SomeTaint: WhyNot?}")
322+
// The TaintToleration plugin now returns a generic error message: "node(s) had untolerated taint(s)"
323+
// See: https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/framework/plugins/tainttoleration/taint_toleration.go
324+
assert.Contains(t, predicateErr.FailingPredicateReasons(), "node(s) had untolerated taint(s)")
325+
assert.Contains(t, predicateErr.Error(), "node(s) had untolerated taint(s)")
326+
// Verify that detailed taint information is still available in debugInfo
324327
assert.Contains(t, predicateErr.Error(), "RandomTaint")
328+
assert.Contains(t, predicateErr.Error(), "SomeTaint")
325329

326330
// with custom predicate checker
327331

0 commit comments

Comments
 (0)