Handle virtual nodes and missing node pools to avoid crash

Author: lxuan94-pp

cluster-autoscaler/cloudprovider/oci/nodepools/oci_cloud_provider.go

@@ -10,9 +10,11 @@ import (
 	"k8s.io/apimachinery/pkg/api/resource"
 	"k8s.io/autoscaler/cluster-autoscaler/cloudprovider"
 	ocicommon "k8s.io/autoscaler/cluster-autoscaler/cloudprovider/oci/common"
+	npconsts "k8s.io/autoscaler/cluster-autoscaler/cloudprovider/oci/nodepools/consts"
 	caerrors "k8s.io/autoscaler/cluster-autoscaler/utils/errors"
 	"k8s.io/autoscaler/cluster-autoscaler/utils/gpu"
 	klog "k8s.io/klog/v2"
+	"strings"
 )
 
 // OciCloudProvider creates a cloud provider object that is compatible with node pools
@@ -86,6 +88,11 @@ func (ocp *OciCloudProvider) HasInstance(node *apiv1.Node) (bool, error) {
 	if err != nil {
 		return true, err
 	}
+	// Handle virtual nodes and missing node pools to avoid crash
+	if np == nil || np.Id() == "" || strings.Contains(instance.InstanceID, npconsts.OciVirtualNodeResourceIdent) {
+		return false, cloudprovider.ErrNotImplemented
+	}
+
 	nodes, err := ocp.manager.GetNodePoolNodes(np)
 	if err != nil {
 		return true, err