Merge pull request #8289 from pmendelski/exclude-injected-node-groups-from-balancing

Filter out non-existing node-groups before scale-up balancing

Author: k8s-ci-robot

cluster-autoscaler/core/scaleup/orchestrator/orchestrator.go

@@ -714,7 +714,16 @@ func (o *ScaleUpOrchestrator) balanceScaleUps(
 	schedulablePodGroups map[string][]estimator.PodEquivalenceGroup,
 ) ([]nodegroupset.ScaleUpInfo, errors.AutoscalerError) {
 	// Recompute similar node groups in case they need to be updated
-	similarNodeGroups := o.ComputeSimilarNodeGroups(nodeGroup, nodeInfos, schedulablePodGroups, now)
+	nodeGroups := o.ComputeSimilarNodeGroups(nodeGroup, nodeInfos, schedulablePodGroups, now)
+
+	// Similar node groups may return injected node groups as they are used for simulations
+	var similarNodeGroups []cloudprovider.NodeGroup
+	for _, ng := range nodeGroups {
+		if ng.Exist() || o.scaleUpExecutor.asyncNodeGroupStateChecker.IsUpcoming(ng) {
+			similarNodeGroups = append(similarNodeGroups, ng)
+		}
+	}
+
 	if similarNodeGroups != nil {
 		// if similar node groups are found, log about them
 		similarNodeGroupIds := make([]string, 0)