Skip to content

Commit db81a58

Browse files
authored
Merge pull request #8588 from towca/jtuznik/race-fix
Fix a race condition in TestNodeLoadFromExistingTaints
2 parents 12ac2eb + 7ecf09e commit db81a58

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

cluster-autoscaler/core/scaledown/unneeded/nodes_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import (
3030
"k8s.io/autoscaler/cluster-autoscaler/core/scaledown/resource"
3131
"k8s.io/autoscaler/cluster-autoscaler/core/scaledown/status"
3232
. "k8s.io/autoscaler/cluster-autoscaler/core/test"
33-
"k8s.io/autoscaler/cluster-autoscaler/processors/nodes"
33+
nodeprocessors "k8s.io/autoscaler/cluster-autoscaler/processors/nodes"
3434
"k8s.io/autoscaler/cluster-autoscaler/simulator"
3535
"k8s.io/autoscaler/cluster-autoscaler/utils/kubernetes"
3636
kube_util "k8s.io/autoscaler/cluster-autoscaler/utils/kubernetes"
@@ -205,7 +205,7 @@ func TestRemovableAt(t *testing.T) {
205205

206206
n := NewNodes(&fakeScaleDownTimeGetter{}, &resource.LimitsFinder{})
207207
n.Update(removableNodes, time.Now())
208-
gotEmptyToRemove, gotDrainToRemove, _ := n.RemovableAt(&ctx, nodes.ScaleDownContext{
208+
gotEmptyToRemove, gotDrainToRemove, _ := n.RemovableAt(&ctx, nodeprocessors.ScaleDownContext{
209209
ActuationStatus: as,
210210
ResourcesLeft: resource.Limits{},
211211
ResourcesWithLimits: []string{},
@@ -218,7 +218,6 @@ func TestRemovableAt(t *testing.T) {
218218
}
219219

220220
func TestNodeLoadFromExistingTaints(t *testing.T) {
221-
222221
deletionCandidateTaint := taints.DeletionCandidateTaint()
223222
currentTime := time.Now()
224223

@@ -275,8 +274,6 @@ func TestNodeLoadFromExistingTaints(t *testing.T) {
275274
t.Run(tc.name, func(t *testing.T) {
276275
t.Parallel()
277276

278-
currentTime = time.Now()
279-
280277
nodes := NewNodes(nil, nil)
281278

282279
allNodeLister := kubernetes.NewTestNodeLister(nil)

0 commit comments

Comments
 (0)