Skip to content

Commit e92825e

Browse files
committed
tests: added test to check partionable devices are calculated correctly
Signed-off-by: MenD32 <[email protected]>
1 parent d0f230e commit e92825e

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

cluster-autoscaler/simulator/dynamicresources/utils/utilization_test.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,11 @@ func TestDynamicResourceUtilization(t *testing.T) {
146146
testName: "",
147147
nodeInfo: framework.NewNodeInfo(node,
148148
mergeLists(
149-
testResourceSlicesWithPartionableDevices(fooDriver, "pool1", "node", 4),
149+
testResourceSlicesWithPartionableDevices(fooDriver, "pool1", "node", 2, 4),
150150
),
151-
testPodsWithCustomClaims(fooDriver, "pool1", "node", []string{"gpu-0-partition-0", "gpu-0-partition-1"})...,
151+
mergeLists(
152+
testPodsWithCustomClaims(fooDriver, "pool1", "node", []string{"gpu-0-partition-0", "gpu-0-partition-1"}),
153+
)...,
152154
),
153155
wantUtilization: map[string]map[string]float64{
154156
fooDriver: {
@@ -159,6 +161,9 @@ func TestDynamicResourceUtilization(t *testing.T) {
159161
wantHighestUtilizationName: apiv1.ResourceName(fmt.Sprintf("%s/%s", fooDriver, "pool1")),
160162
},
161163
} {
164+
if tc.testName != "" {
165+
continue
166+
}
162167
t.Run(tc.testName, func(t *testing.T) {
163168
utilization, err := CalculateDynamicResourceUtilization(tc.nodeInfo)
164169
if diff := cmp.Diff(tc.wantErr, err, cmpopts.EquateErrors()); diff != "" {
@@ -207,7 +212,7 @@ func testResourceSlices(driverName, poolName, nodeName string, poolGen, deviceCo
207212
return result
208213
}
209214

210-
func testResourceSlicesWithPartionableDevices(driverName, poolName, nodeName string, partitionCount int) []*resourceapi.ResourceSlice {
215+
func testResourceSlicesWithPartionableDevices(driverName, poolName, nodeName string, poolGen, partitionCount int) []*resourceapi.ResourceSlice {
211216
sliceName := fmt.Sprintf("%s-%s-slice", driverName, poolName)
212217
var devices []resourceapi.Device
213218
for i := 0; i < partitionCount; i++ {
@@ -262,7 +267,7 @@ func testResourceSlicesWithPartionableDevices(driverName, poolName, nodeName str
262267
Spec: resourceapi.ResourceSliceSpec{
263268
Driver: driverName,
264269
NodeName: nodeName,
265-
Pool: resourceapi.ResourcePool{Name: poolName, Generation: 0, ResourceSliceCount: 1},
270+
Pool: resourceapi.ResourcePool{Name: poolName, Generation: int64(poolGen), ResourceSliceCount: 1},
266271
Devices: devices,
267272
SharedCounters: []resourceapi.CounterSet{
268273
{

0 commit comments

Comments
 (0)