Skip to content

Commit e97c112

Browse files
committed
Reword comment since there is no race condition
1 parent 0b16bbd commit e97c112

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cluster-autoscaler/core/scaledown/actuation/actuator_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1302,7 +1302,7 @@ func runStartDeletionTest(t *testing.T, tc startDeletionTestCase, force bool) {
13021302
// Verify ScaleDownNodes looks as expected.
13031303
ignoreSdNodeOrder := cmpopts.SortSlices(func(a, b *status.ScaleDownNode) bool { return a.Node.Name < b.Node.Name })
13041304
cmpNg := cmp.Comparer(func(a, b *testprovider.TestNodeGroup) bool { return a.Id() == b.Id() })
1305-
// Deletion taint may be lifted by goroutine, ignore taints to avoid race condition
1305+
// Nodes will have deletion taints, skipping them here since we check them later
13061306
ignoreTaints := cmpopts.IgnoreFields(apiv1.NodeSpec{}, "Taints")
13071307
statusCmpOpts := cmp.Options{ignoreSdNodeOrder, cmpNg, cmpopts.EquateEmpty(), ignoreTaints}
13081308
if diff := cmp.Diff(wantScaleDownNodes, gotScaleDownNodes, statusCmpOpts); diff != "" {

0 commit comments

Comments
 (0)