Configure VPA for parallel e2e tests (#8715)

* Configure VPA for parallel e2e tests

* Set GOBIN to make the script more portable

Author: adrianmoisey

vertical-pod-autoscaler/.gitignore

@@ -1,5 +1,6 @@
 # vendor directories
 vendor/
 e2e/vendor/
+e2e/v1/v1.test
 # created from deploy-for-e2e-locally.sh
 hack/e2e/vpa-rbac.yaml

vertical-pod-autoscaler/e2e/v1/actuation.go

@@ -207,7 +207,8 @@ var _ = ActuationSuiteE2eDescribe("Actuation", func() {
 		gomega.Expect(err).NotTo(gomega.HaveOccurred())
 	})
 
-	ginkgo.It("falls back to evicting pods when resize is Deferred and more than 5 minute has elapsed since last in-place update when update mode is InPlaceOrRecreate", func() {
+	// Consumes the entire node's CPU, causing other pods to be pending - requires WithSerial()
+	framework.It("falls back to evicting pods when resize is Deferred and more than 5 minute has elapsed since last in-place update when update mode is InPlaceOrRecreate", framework.WithSerial(), func() {
 		ginkgo.By("Setting up a hamster deployment")
 		replicas := int32(2)
 		SetupHamsterDeployment(f, "100m", "100Mi", replicas)

vertical-pod-autoscaler/e2e/v1/updater.go

@@ -39,7 +39,8 @@ var _ = UpdaterE2eDescribe("Updater", func() {
 	f := framework.NewDefaultFramework("vertical-pod-autoscaling")
 	f.NamespacePodSecurityEnforceLevel = podsecurity.LevelBaseline
 
-	ginkgo.It("evicts pods when Admission Controller status available", func() {
+	// Sets up a lease object updated periodically to signal - requires WithSerial()
+	framework.It("evicts pods when Admission Controller status available", framework.WithSerial(), func() {
 		const statusUpdateInterval = 10 * time.Second
 
 		ginkgo.By("Setting up the Admission Controller status")
@@ -69,7 +70,8 @@ var _ = UpdaterE2eDescribe("Updater", func() {
 		gomega.Expect(err).NotTo(gomega.HaveOccurred())
 	})
 
-	ginkgo.It("evicts pods for downscaling", func() {
+	// Sets up a lease object updated periodically to signal - requires WithSerial()
+	framework.It("evicts pods for downscaling", framework.WithSerial(), func() {
 		const statusUpdateInterval = 10 * time.Second
 
 		ginkgo.By("Setting up the Admission Controller status")
@@ -98,8 +100,8 @@ var _ = UpdaterE2eDescribe("Updater", func() {
 		err := WaitForPodsEvicted(f, podList)
 		gomega.Expect(err).NotTo(gomega.HaveOccurred())
 	})
-
-	ginkgo.It("does not evict pods for downscaling when EvictionRequirement prevents it", func() {
+	// Sets up a lease object updated periodically to signal - requires WithSerial()
+	framework.It("does not evict pods for downscaling when EvictionRequirement prevents it", framework.WithSerial(), func() {
 		const statusUpdateInterval = 10 * time.Second
 
 		ginkgo.By("Setting up the Admission Controller status")
@@ -140,7 +142,8 @@ var _ = UpdaterE2eDescribe("Updater", func() {
 		CheckNoPodsEvicted(f, MakePodSet(podList))
 	})
 
-	ginkgo.It("In-place update pods when Admission Controller status available", func() {
+	// Sets up a lease object updated periodically to signal - requires WithSerial()
+	framework.It("In-place update pods when Admission Controller status available", framework.WithSerial(), func() {
 		const statusUpdateInterval = 10 * time.Second
 
 		ginkgo.By("Setting up the Admission Controller status")
@@ -171,7 +174,8 @@ var _ = UpdaterE2eDescribe("Updater", func() {
 		gomega.Expect(err).NotTo(gomega.HaveOccurred())
 	})
 
-	ginkgo.It("Does not evict pods for downscaling in-place", func() {
+	// Sets up a lease object updated periodically to signal - requires WithSerial()
+	framework.It("Does not evict pods for downscaling in-place", framework.WithSerial(), func() {
 		const statusUpdateInterval = 10 * time.Second
 
 		ginkgo.By("Setting up the Admission Controller status")

vertical-pod-autoscaler/hack/run-e2e-tests.sh

@@ -43,6 +43,9 @@ fi
 SUITE=$1
 
 export GO111MODULE=on
+# todo(adrianmoisey): Make the setting of GOBIN nicer
+ABSOLUTE_PATH=$(realpath "${SCRIPT_ROOT}")
+export GOBIN="${ABSOLUTE_PATH}/e2e/_output/bin"
 
 export WORKSPACE=${WORKSPACE:-/workspace/_artifacts}
 
@@ -52,11 +55,14 @@ if [ "${TEST_WITH_FEATURE_GATES_ENABLED:-}" == "true" ]; then
   SKIP=""
 fi
 
+NUMPROC=${NUMPROC:-4}
+
 case ${SUITE} in
   recommender|updater|admission-controller|actuation|full-vpa)
     export KUBECONFIG=$HOME/.kube/config
     pushd ${SCRIPT_ROOT}/e2e
-    go test ./v1/*go -v --test.timeout=150m --args --ginkgo.v=true --ginkgo.focus="\[VPA\] \[${SUITE}\]" --report-dir=${WORKSPACE} --disable-log-dump --ginkgo.timeout=150m ${SKIP}
+    go install github.com/onsi/ginkgo/v2/ginkgo
+    ${GOBIN}/ginkgo build v1/ && ${GOBIN}/ginkgo --nodes=$NUMPROC --focus="\[VPA\] \[${SUITE}\]" v1/v1.test -- --report-dir=${WORKSPACE} --disable-log-dump ${SKIP}
     V1_RESULT=$?
     popd
     echo v1 test result: ${V1_RESULT}