Coreweave UpdateNodeGroup

needs to return empty slice when nodepools autoscaling is disabled

Author: keedya

cluster-autoscaler/cloudprovider/coreweave/coreweave_manager.go

@@ -122,7 +122,7 @@ func (m *CoreWeaveManager) UpdateNodeGroup() ([]cloudprovider.NodeGroup, error)
 	// If no node pools are found, return an empty slice
 	if len(nodepools) == 0 {
 		klog.Info("No node pools found, returning empty node groups")
-		return nil, nil
+		return []cloudprovider.NodeGroup{}, nil
 	}
 	klog.V(4).Infof("Found %d node pools", len(nodepools))
 	m.nodeGroups = make([]cloudprovider.NodeGroup, len(nodepools))

cluster-autoscaler/cloudprovider/coreweave/coreweave_manager_test.go

@@ -193,3 +193,36 @@ func TestListNodePools_EmptyList(t *testing.T) {
 		t.Errorf("expected empty nodepools list, got %d", len(nodePools))
 	}
 }
+
+func TestUpdateNodeGroup_EmptyNodePools(t *testing.T) {
+	// Create a nodepool with autoscaling disabled - this will result in empty list after filtering
+	obj := map[string]interface{}{
+		"apiVersion": coreWeaveGroup + "/" + coreWeaveVersion,
+		"kind":       coreWeaveResource,
+		"metadata": map[string]interface{}{
+			"name":      "np1",
+			"namespace": "default",
+			"uid":       "uid1",
+		},
+		"spec": map[string]interface{}{
+			"minNodes":    int64(1),
+			"maxNodes":    int64(5),
+			"targetNodes": int64(3),
+			"autoscaling": false, // Autoscaling disabled - will be filtered out
+		},
+	}
+	item := unstructured.Unstructured{Object: obj}
+	manager := makeTestManagerWithNodePools(nil, item)
+
+	// UpdateNodeGroup should return empty slice when all nodepools have autoscaling disabled
+	nodeGroups, err := manager.UpdateNodeGroup()
+	if err != nil {
+		t.Errorf("unexpected error: %v", err)
+	}
+	if nodeGroups == nil {
+		t.Error("expected empty slice, got nil")
+	}
+	if len(nodeGroups) != 0 {
+		t.Errorf("expected empty node groups, got %d", len(nodeGroups))
+	}
+}