Start fixing tests for CSINode objects

Author: gnufied

cluster-autoscaler/core/podlistprocessor/filter_out_expendable_test.go

@@ -110,7 +110,7 @@ func TestFilterOutExpendable(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			processor := NewFilterOutExpendablePodListProcessor()
 			snapshot := testsnapshot.NewTestSnapshotOrDie(t)
-			err := snapshot.SetClusterState(tc.nodes, nil, nil)
+			err := snapshot.SetClusterState(tc.nodes, nil, nil, nil)
 			assert.NoError(t, err)
 
 			pods, err := processor.Process(&ca_context.AutoscalingContext{

cluster-autoscaler/core/podlistprocessor/filter_out_schedulable_test.go

@@ -280,7 +280,7 @@ func BenchmarkFilterOutSchedulable(b *testing.B) {
 				}
 
 				clusterSnapshot := snapshotFactory()
-				if err := clusterSnapshot.SetClusterState(nodes, scheduledPods, nil); err != nil {
+				if err := clusterSnapshot.SetClusterState(nodes, scheduledPods, nil, nil); err != nil {
 					assert.NoError(b, err)
 				}
 

cluster-autoscaler/core/scaledown/actuation/actuator_test.go

@@ -1228,7 +1228,7 @@ func runStartDeletionTest(t *testing.T, tc startDeletionTestCase, force bool) {
 		t.Fatalf("Couldn't create daemonset lister")
 	}
 
-	registry := kube_util.NewListerRegistry(nil, nil, podLister, pdbLister, dsLister, nil, nil, nil, nil)
+	registry := kube_util.NewListerRegistry(nil, nil, nil, podLister, pdbLister, dsLister, nil, nil, nil, nil)
 	autoscalingCtx, err := NewScaleTestAutoscalingContext(opts, fakeClient, registry, provider, nil, nil)
 	if err != nil {
 		t.Fatalf("Couldn't set up autoscaling context: %v", err)
@@ -1541,7 +1541,7 @@ func TestStartDeletionInBatchBasic(t *testing.T) {
 
 			podLister := kube_util.NewTestPodLister([]*apiv1.Pod{})
 			pdbLister := kube_util.NewTestPodDisruptionBudgetLister([]*policyv1.PodDisruptionBudget{})
-			registry := kube_util.NewListerRegistry(nil, nil, podLister, pdbLister, nil, nil, nil, nil, nil)
+			registry := kube_util.NewListerRegistry(nil, nil, nil, podLister, pdbLister, nil, nil, nil, nil, nil)
 			autoscalingCtx, err := NewScaleTestAutoscalingContext(opts, fakeClient, registry, provider, nil, nil)
 			if err != nil {
 				t.Fatalf("Couldn't set up autoscaling context: %v", err)

cluster-autoscaler/core/scaledown/actuation/drain_test.go

@@ -139,7 +139,7 @@ func TestDaemonSetEvictionForEmptyNodes(t *testing.T) {
 			provider := testprovider.NewTestCloudProviderBuilder().Build()
 			provider.AddNodeGroup("ng1", 1, 10, 1)
 			provider.AddNode("ng1", n1)
-			registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, nil, nil)
+			registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, nil, nil, nil)
 
 			autoscalingCtx, err := NewScaleTestAutoscalingContext(options, fakeClient, registry, provider, nil, nil)
 			assert.NoError(t, err)

cluster-autoscaler/core/scaledown/actuation/group_deletion_scheduler_test.go

@@ -146,7 +146,7 @@ func TestScheduleDeletion(t *testing.T) {
 			if err != nil {
 				t.Fatalf("Couldn't create daemonset lister")
 			}
-			registry := kube_util.NewListerRegistry(nil, nil, podLister, pdbLister, dsLister, nil, nil, nil, nil)
+			registry := kube_util.NewListerRegistry(nil, nil, nil, podLister, pdbLister, dsLister, nil, nil, nil, nil)
 			autoscalingCtx, err := NewScaleTestAutoscalingContext(opts, fakeClient, registry, provider, nil, nil)
 			if err != nil {
 				t.Fatalf("Couldn't set up autoscaling context: %v", err)

cluster-autoscaler/core/scaledown/actuation/softtaint_test.go

@@ -67,7 +67,7 @@ func TestSoftTaintUpdate(t *testing.T) {
 		MaxBulkSoftTaintCount: 1,
 		MaxBulkSoftTaintTime:  3 * time.Second,
 	}
-	registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, nil, nil)
+	registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, nil, nil, nil)
 
 	actx, err := test.NewScaleTestAutoscalingContext(options, fakeClient, registry, provider, nil, nil)
 	assert.NoError(t, err)
@@ -151,7 +151,7 @@ func TestSoftTaintTimeLimit(t *testing.T) {
 		MaxBulkSoftTaintCount: 10,
 		MaxBulkSoftTaintTime:  maxSoftTaintDuration,
 	}
-	registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, nil, nil)
+	registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, nil, nil, nil)
 
 	actx, err := test.NewScaleTestAutoscalingContext(options, fakeClient, registry, provider, nil, nil)
 	assert.NoError(t, err)

cluster-autoscaler/core/scaledown/eligibility/eligibility_test.go

@@ -233,7 +233,7 @@ func TestFilterOutUnremovable(t *testing.T) {
 			if err != nil {
 				t.Fatalf("Could not create autoscaling context: %v", err)
 			}
-			if err := autoscalingCtx.ClusterSnapshot.SetClusterState(tc.nodes, tc.pods, tc.draSnapshot); err != nil {
+			if err := autoscalingCtx.ClusterSnapshot.SetClusterState(tc.nodes, tc.pods, tc.draSnapshot, nil); err != nil {
 				t.Fatalf("Could not SetClusterState: %v", err)
 			}
 			unremovableNodes := unremovable.NewNodes()

cluster-autoscaler/core/scaledown/planner/controller_test.go

@@ -125,7 +125,7 @@ func TestReplicasCounter(t *testing.T) {
 	jobLister, _ := kube_util.NewTestJobLister([]*batchv1.Job{job, unsetJob, jobWithSucceededReplicas})
 	rsLister, _ := kube_util.NewTestReplicaSetLister([]*appsv1.ReplicaSet{rs, unsetRs})
 	ssLister, _ := kube_util.NewTestStatefulSetLister([]*appsv1.StatefulSet{sS})
-	listers := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, rcLister, jobLister, rsLister, ssLister)
+	listers := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, rcLister, jobLister, rsLister, ssLister)
 	testCases := []struct {
 		name         string
 		ownerRef     metav1.OwnerReference

cluster-autoscaler/core/scaledown/planner/planner_test.go

@@ -487,7 +487,7 @@ func TestUpdateClusterState(t *testing.T) {
 			}
 			rsLister, err := kube_util.NewTestReplicaSetLister(tc.replicasSets)
 			assert.NoError(t, err)
-			registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, rsLister, nil)
+			registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, nil, rsLister, nil)
 			provider := testprovider.NewTestCloudProviderBuilder().Build()
 			provider.AddNodeGroup("ng1", 0, 0, 0)
 			for _, node := range tc.nodes {
@@ -822,6 +822,7 @@ func TestNewPlannerWithExistingDeletionCandidateNodes(t *testing.T) {
 				&fake.Clientset{},
 				kube_util.NewListerRegistry(
 					allNodeLister,
+					nil,
 					readyNodeLister,
 					nil, nil, nil, nil, nil, nil, nil,
 				),

cluster-autoscaler/core/scaledown/unneeded/nodes_test.go

@@ -199,7 +199,7 @@ func TestRemovableAt(t *testing.T) {
 
 			rsLister, err := kube_util.NewTestReplicaSetLister(nil)
 			assert.NoError(t, err)
-			registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, rsLister, nil)
+			registry := kube_util.NewListerRegistry(nil, nil, nil, nil, nil, nil, nil, nil, rsLister, nil)
 			autoscalingCtx, err := NewScaleTestAutoscalingContext(config.AutoscalingOptions{ScaleDownSimulationTimeout: 5 * time.Minute}, &fake.Clientset{}, registry, provider, nil, nil)
 			assert.NoError(t, err)
 
@@ -282,7 +282,7 @@ func TestNodeLoadFromExistingTaints(t *testing.T) {
 			readyNodeLister := kubernetes.NewTestNodeLister(nil)
 			readyNodeLister.SetNodes(tc.allNodes)
 
-			listerRegistry := kube_util.NewListerRegistry(allNodeLister, readyNodeLister,
+			listerRegistry := kube_util.NewListerRegistry(allNodeLister, nil, readyNodeLister,
 				nil, nil, nil, nil, nil, nil, nil)
 
 			nodes.LoadFromExistingTaints(listerRegistry, currentTime, tc.nodeDeletionCandidateTTL)